yaml plugin: provide file id to transform function #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reason for this change: i need to apply different content transformations depending on which file the data came from without knowing the file, the transformer function has to rely on brittle heuristics to identify the file based on the content loaded from it (which can obviously change over time) non-breaking change since people don't have to use the extra transformer argument
NotWoods
requested changes
Oct 21, 2020
|
@NotWoods Odd. If I run |
NotWoods
reviewed
Oct 21, 2020
|
Ah, different directory separators on UNIX ( |
NotWoods
reviewed
Oct 22, 2020
|
I was able to get it. |
shellscape
pushed a commit
that referenced
this pull request
Oct 22, 2020
NotWoods
pushed a commit
that referenced
this pull request
Oct 22, 2020
|
@NotWoods Can you say when this will be published? |
|
@janosh we typically make weekly publish rounds for plugins. we have a lot moving parts this week so don't be surprised if this takes until early next week to be seen on NPM. (We're not quite ready for automated publishing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
YAMLThis PR contains:
Are tests included?
Breaking Changes?
Non-breaking change since people don't have to use the extra transformer argument.
Description
Reason for this change: I need to apply different content transformations depending on which file the data came from. Without knowing the file, the transformer function has to rely on brittle heuristics to identify the file based on its content (which can obviously change over time).
I think a new test case isn't needed for this but happy to provide one if someone thinks otherwise.