Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typescript): error when no tsconfig and no rootDir #794

Merged
merged 2 commits into from Feb 6, 2021
Merged

feat(typescript): error when no tsconfig and no rootDir #794

merged 2 commits into from Feb 6, 2021

Conversation

shellscape
Copy link
Collaborator

Rollup Plugin Name: typescript

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers: Fixes #735

Description

This PR adds a new error message when the tsconfig option is omitted and neither rootDir nor rootDirs are specified in the plugin options. The issue is that without a directory from which to read the tsconfig.json file, and without those root options, TS doesn't know where to start things off.

@shellscape shellscape mentioned this pull request Feb 5, 2021
Closed
@shellscape shellscape merged commit cbfd779 into master Feb 6, 2021
@shellscape shellscape deleted the fix/typescript/no-tsconfig branch February 6, 2021 00:57
@benmccann benmccann mentioned this pull request Feb 24, 2021
Merged
9 tasks
This was referenced Mar 5, 2021
Closed
Closed
shellscape pushed a commit that referenced this pull request Mar 10, 2021
@benmccann
fix(typescript): bump TypeScript version (#818)
4f4c25d 
* chore(typescript): bump TypeScript version

* Revert "feat(typescript): error when no tsconfig and no rootDir (#794)"

This reverts commit cbfd779.
This was referenced Mar 11, 2021
Closed
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Closed
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotWoods NotWoods NotWoods approved these changes

@TrySound TrySound Awaiting requested review from TrySound

@lukastaegert lukastaegert Awaiting requested review from lukastaegert

Assignees
No one assigned
Labels
🔌 plugin-typescript pr³ 🔧 feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typescript fails when compilerOptions are specified without using tsconfig.json
2 participants
@shellscape @NotWoods