Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Make unwrapExports only pick out default when it exists #226

Merged
merged 1 commit into from Oct 7, 2017
Merged

Make unwrapExports only pick out default when it exists #226

merged 1 commit into from Oct 7, 2017

Conversation

marijnh
Copy link
Contributor

@marijnh marijnh commented Sep 8, 2017

Now that I'm actually awake, I think it's rather obvious how issue #224 should be solved. Take a look!

@marijnh
Copy link
Contributor Author

marijnh commented Oct 3, 2017

Heyyy there 👋, any chance this could get a look?

@lukastaegert
Copy link
Member

Hi @marijnh, sorry you have been waiting for so long. I just took a look at your change and to me it seems that this should work well in all cases 👍.

However, as this issue is somewhat non-trivial, could you add a test that is fixed by your change? Something like what you posted as an example in #224 should be fine. This is important as it
serves as documentation for this change. If anyone wonders why this change was made and starts refactoring code, the red test will tell them right away.

If you don't feel up to it, I can do it for you, but this is your PR after all 😉

@marijnh
Copy link
Contributor Author

marijnh commented Oct 7, 2017

Good point. I've updated the commit to include a test.

@lukastaegert lukastaegert merged commit 83315ad into rollup:master Oct 7, 2017
@lukastaegert
Copy link
Member

Until @Rich-Harris is back at the internet to publish a new version, you can install a version containing this fix via

npm install github:rollup-plugin-commonjs@rollup/rollup-plugin-commonjs#bundled-v8.2.3

which should contain all necessary build artefacts.

@adrianheine
Copy link
Contributor

8.2.4 is released now and includes the fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants