Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Make generated helper file have .js extension in preserveModules mode #373

Merged
merged 3 commits into from
Apr 2, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/helpers.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
export const PROXY_PREFIX = '\0commonjs-proxy:';
export const EXTERNAL_PREFIX = '\0commonjs-external:';
export const HELPERS_ID = '\0commonjsHelpers';
export const HELPERS_ID = '\0commonjsHelpers.js';

// `x['default']` is used instead of `x.default` for backward compatibility with ES3 browsers.
// Minifiers like uglify will usually transpile it back if compatibility with ES3 is not enabled.
export const HELPERS = `
export var commonjsGlobal = typeof window !== 'undefined' ? window : typeof global !== 'undefined' ? global : typeof self !== 'undefined' ? self : {};
export var commonjsGlobal = typeof globalThis !== 'undefined' ? globalThis : typeof window !== 'undefined' ? window : typeof global !== 'undefined' ? global : typeof self !== 'undefined' ? self : {};

export function commonjsRequire () {
throw new Error('Dynamic requires are not currently supported by rollup-plugin-commonjs');
Expand Down
2 changes: 1 addition & 1 deletion test/form/dynamic-template-literal/output.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import * as commonjsHelpers from 'commonjsHelpers';
import * as commonjsHelpers from 'commonjsHelpers.js';

var pe = 'pe';
var foo = commonjsHelpers.commonjsRequire(`ta${pe}`);
Expand Down
2 changes: 1 addition & 1 deletion test/form/typeof-module-exports/output.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import * as commonjsHelpers from 'commonjsHelpers';
import * as commonjsHelpers from 'commonjsHelpers.js';

var input = commonjsHelpers.createCommonjsModule(function (module, exports) {
var foo = 42;
Expand Down