Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignore global #86

Merged
merged 2 commits into from Aug 31, 2016

Conversation

Projects
None yet
3 participants
@dmitrage
Copy link
Contributor

commented Aug 11, 2016

No description provided.

@TrySound

This comment has been minimized.

Copy link
Member

commented Aug 11, 2016

@dmitrage Hi! Thanks for PR. Can you provide test case please?

@dmitrage

This comment has been minimized.

Copy link
Contributor Author

commented Aug 11, 2016

@TrySound Hi! Instead I've added comment with "require" to the existing one that was actually skipped because of the firstpass check.

Or should I create different cases for the firstpass regexp, Identifier and ThisExpression in this PR?

@TrySound

This comment has been minimized.

Copy link
Member

commented Aug 11, 2016

@dmitrage Better different. Caz it's not actually ignore-global

@TrySound

This comment has been minimized.

Copy link
Member

commented Aug 11, 2016

But you may combine them in one.

@dmitrage

This comment has been minimized.

Copy link
Contributor Author

commented Aug 11, 2016

@TrySound I've updated test case to cover ignoreGlobal feature:

  • try to skip module by firstpass, excluding "global" pattern from regexp
  • do not mark "uses.global" when "global" identifier is found (implemented in this PR)
  • do not mark "uses.global" when global "this" is found

Is that what you meant?

@Rich-Harris Rich-Harris merged commit 7e557a7 into rollup:master Aug 31, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Rich-Harris

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2016

Thanks! Sorry for the slow turnaround, released as 4.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.