Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

transform all files, not just those with names ending .js #6

Merged
merged 2 commits into from
Sep 19, 2016

Conversation

tyler-johnson
Copy link
Contributor

Hello.

I am currently working on a compile-to-JS language and I have decided to use rollup internally to handle the merging of the resulting JS sources. I use this plugin to inject some shared variables and it is almost perfect, except the original filenames do not end in .js.

So, would it be possible to remove the extname() line? Obviously this is a breaking change, however I figure that users who require the current set up could just add include: ["*.js"] to their options.

Thoughts?

@tyler-johnson
Copy link
Contributor Author

I've gone ahead and published a forked copy with just these changes in them: @mrgalaxy/rollup-plugin-inject. Please let me know if/when you're interested in merging this.

@Rich-Harris Rich-Harris merged commit 91fcd76 into rollup:master Sep 19, 2016
Rich-Harris added a commit that referenced this pull request Sep 19, 2016
@Rich-Harris
Copy link
Contributor

Apologies for the looooong delay in responding – I've released this as 2.0.0. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants