-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scoped packages cause build to fail since 0.16.2 #131
Comments
Ah, whoops! I know why this is – since #126, Fixing it ought to be straightforward but it's a little tricky to test – could I ask you to try plonking this code inside function defaultExternalResolver(id, importer) {
// for now, only node_modules is supported, and only jsnext:main
var root = absolutePath.exec(importer)[0];
var dir = dirname(importer);
// `foo` should use jsnext:main, but `foo/src/bar` shouldn't
var parts = id.split(/[\/\\]/);
+ // npm scoped packages – @user/package
+ if (parts[0][0] === '@' && parts[1]) {
+ var user = parts.shift();
+ parts[0] = user + '/' + parts[0];
+ }
while (dir !== root && dir !== '.') { ...and verifying that it works please? |
Tested it and can confirm that it works. Thanks! |
whoops, closed by mistake! |
Finally got round to actually releasing this fix, as 0.17.2 |
Good things take time :) Keep up the good work! |
I use scoped modules like:
The external package would be:
This works in 0.16.1, but since version 0.16.2 the bundling fails with this error:
Rollup doesn't include the external module's entry point for some reason. Other external modules with no scope work just fine!
The text was updated successfully, but these errors were encountered: