Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollup hangs when bundle with react 16 #1711

Closed
yinhangfeng opened this issue Nov 9, 2017 · 9 comments
Closed

rollup hangs when bundle with react 16 #1711

yinhangfeng opened this issue Nov 9, 2017 · 9 comments

Comments

@yinhangfeng
Copy link

yinhangfeng commented Nov 9, 2017

example: https://github.com/yinhangfeng/rollup-example
rollup: 0.51.1
node: 8.9.0
npm: 5.5.1

@drcmda
Copy link

drcmda commented Nov 9, 2017

Same in 0.51.2

@kemsky
Copy link

kemsky commented Nov 9, 2017

Hangs while bundling angular5 app, node 8.9.0, typescript 2.4.2
rollup 0.51.1, 0.51.2

@nathancahill
Copy link
Contributor

This isn't the source of your error, but output filename in your rollup config should be output.file instead of output.dest

@kemsky
Copy link

kemsky commented Nov 10, 2017

    output: {
        file: build.config.dist + '/main.bundle.js',
        format: 'iife'
    },

Thats what I have in the config file.

@nathancahill
Copy link
Contributor

Not your Angular issue, @kemsky. You might want to open a separate issue for that, since this issue has a reproducible test.

@lukastaegert
Copy link
Member

To anyone who has issues with rollup hanging without any error message, please do not post any new issues yet but keep watching this one. I have a good idea what is causing this and I currently investigate several ways how to work around it.

@kemsky
Copy link

kemsky commented Nov 11, 2017

@lukastaegert , while v0.51.5 probably fixed original issue, my problem still exists. Unfortunately project is very large, so I don't know when I'll be able to create reproducible sample.

@lukastaegert
Copy link
Member

Since you are using angular 5, a simple repo with angular 5 similar to the one given above that has this issue would be really helpful. For the future, I plan on adding some simple projects like these to rollup's repo as automated acceptance tests.

Just to be sure, I assume rollup works for you if you use the option treeshake: false?

@kemsky
Copy link

kemsky commented Nov 16, 2017

@lukastaegert, see #1733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants