Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import() with template literals pass undefined to resolveDynamicImport hook #2980

Closed
tivac opened this issue Jul 3, 2019 · 1 comment · Fixed by #2984
Closed

import() with template literals pass undefined to resolveDynamicImport hook #2980

tivac opened this issue Jul 3, 2019 · 1 comment · Fixed by #2984
Labels
t¹ 🐞 bug

Comments

@tivac
Copy link
Contributor

tivac commented Jul 3, 2019

The resolveDynamicImport plugin hook doesn't seem to work correctly with template literals. It seems like it should!

  • Rollup Version: 1.16.4
  • Operating System (or Browser): Windows 10
  • Node Version: 12.6.0

How Do We Reproduce?

  1. npx degit tivac/rollup-resolvedynamicimport-issue
  2. npm install
  3. npm start

Expected Behavior

Two AST nodes are printed to the console

Actual Behavior

undefined is printed first, then an AST node is printed.
@lukastaegert lukastaegert mentioned this issue Jul 4, 2019
Merged
9 tasks
@lukastaegert
Copy link
Member

Thanks, you are absolutely right, fix at #2984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t¹ 🐞 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always forward AST nodes for unresolvable dynamic imports rollup/rollup
2 participants
@tivac @lukastaegert