Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI]: Switch over to a less verbose argument parser library #3376

Closed
jamesgeorge007 opened this issue Feb 8, 2020 · 6 comments · Fixed by #3377
Closed

[CLI]: Switch over to a less verbose argument parser library #3376

jamesgeorge007 opened this issue Feb 8, 2020 · 6 comments · Fixed by #3377

Comments

@jamesgeorge007
Copy link
Contributor

Expected Behavior / Situation

As of now the CLI depends on minimist for the purpose of argument parsing which isn't actively maintained anymore. Switching over to any of the better solutions, say commander.js would be a better idea.

Actual Behavior / Situation

Consumes an arg-parser library which is no longer actively maintained.

Modification Proposal

Switch over to a better argument parser library.

@jamesgeorge007
Copy link
Contributor Author

Since this calls for a major refactor, I would love to hear out from the maintainers.

@shellscape
Copy link
Contributor

I like where the motivation is coming from, but Commander is a hard vote no from me. It's way overkill for our needs. yargs-parser would be much more prudent.

@jamesgeorge007
Copy link
Contributor Author

Sounds good. So shall I go ahead or should we wait to hear what others have to say?

@shellscape
Copy link
Contributor

Definitely wait for more input.

@lukastaegert
Copy link
Member

yargs-parser looks like it can be configured to work the same way as minimist with regard to objects and negations and does not look too big. Definitely worth a shot.

@LarsDenBakker
Copy link
Contributor

I've been using https://www.npmjs.com/package/command-line-args for a lot of CLIs, it works out pretty well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants