Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary ASI in output #3547

Open
guybedford opened this issue May 9, 2020 · 2 comments
Open

Avoid unnecessary ASI in output #3547

guybedford opened this issue May 9, 2020 · 2 comments

Comments

@guybedford
Copy link
Contributor

guybedford commented May 9, 2020

Feature Use Case

One of the great features of Rollup is the way it uses magic string to retain the original source code formatting.

It seems there is some automatic semicolon insertion though that is affecting this process.

For example, notice how Preact built with Rollup inserts semicolons in the code even where it is untouched by Rollup optimization (the first semicolon is after the removeChild(n) expression):

http://rollupjs.org/repl/?version=2.8.2&shareable=%7B%22modules%22%3A%5B%7B%22name%22%3A%22main.js%22%2C%22code%22%3A%22var%20n%2Cl%2Cu%2Ci%2Ct%2Cr%2Co%2Cf%2Ce%3D%7B%7D%2Cc%3D%5B%5D%2Cs%3D%2Facit%7Cex(%3F%3As%7Cg%7Cn%7Cp%7C%24)%7Crph%7Cgrid%7Cows%7Cmnc%7Cntw%7Cine%5Bch%5D%7Czoo%7C%5Eord%2Fi%3Bfunction%20a(n%2Cl)%7Bfor(var%20u%20in%20l)n%5Bu%5D%3Dl%5Bu%5D%3Breturn%20n%7Dfunction%20v(n)%7Bvar%20l%3Dn.parentNode%3Bl%26%26l.removeChild(n)%7Dfunction%20h(n%2Cl%2Cu)%7Bvar%20i%2Ct%3Darguments%2Cr%3D%7B%7D%3Bfor(i%20in%20l)%5C%22key%5C%22!%3D%3Di%26%26%5C%22ref%5C%22!%3D%3Di%26%26(r%5Bi%5D%3Dl%5Bi%5D)%3Bif(arguments.length%3E3)for(u%3D%5Bu%5D%2Ci%3D3%3Bi%3Carguments.length%3Bi%2B%2B)u.push(t%5Bi%5D)%3Bif(null!%3Du%26%26(r.children%3Du)%2C%5C%22function%5C%22%3D%3Dtypeof%20n%26%26null!%3Dn.defaultProps)for(i%20in%20n.defaultProps)void%200%3D%3D%3Dr%5Bi%5D%26%26(r%5Bi%5D%3Dn.defaultProps%5Bi%5D)%3Breturn%20p(n%2Cr%2Cl%26%26l.key%2Cl%26%26l.ref%2Cnull)%7Dfunction%20p(l%2Cu%2Ci%2Ct%2Cr)%7Bvar%20o%3D%7Btype%3Al%2Cprops%3Au%2Ckey%3Ai%2Cref%3At%2C__k%3Anull%2C__%3Anull%2C__b%3A0%2C__e%3Anull%2C__d%3Avoid%200%2C__c%3Anull%2Cconstructor%3Avoid%200%2C__v%3Ar%7D%3Breturn%20null%3D%3Dr%26%26(o.__v%3Do)%2Cn.vnode%26%26n.vnode(o)%2Co%7Dfunction%20y()%7Breturn%7B%7D%7Dfunction%20d(n)%7Breturn%20n.children%7Dfunction%20m(n%2Cl)%7Bthis.props%3Dn%2Cthis.context%3Dl%7Dfunction%20w(n%2Cl)%7Bif(null%3D%3Dl)return%20n.__%3Fw(n.__%2Cn.__.__k.indexOf(n)%2B1)%3Anull%3Bfor(var%20u%3Bl%3Cn.__k.length%3Bl%2B%2B)if(null!%3D(u%3Dn.__k%5Bl%5D)%26%26null!%3Du.__e)return%20u.__e%3Breturn%5C%22function%5C%22%3D%3Dtypeof%20n.type%3Fw(n)%3Anull%7Dfunction%20k(n)%7Bvar%20l%2Cu%3Bif(null!%3D(n%3Dn.__)%26%26null!%3Dn.__c)%7Bfor(n.__e%3Dn.__c.base%3Dnull%2Cl%3D0%3Bl%3Cn.__k.length%3Bl%2B%2B)if(null!%3D(u%3Dn.__k%5Bl%5D)%26%26null!%3Du.__e)%7Bn.__e%3Dn.__c.base%3Du.__e%3Bbreak%7Dreturn%20k(n)%7D%7Dfunction%20g(l)%7B(!l.__d%26%26(l.__d%3D!0)%26%26u.push(l)%26%26!i%2B%2B%7C%7Cr!%3D%3Dn.debounceRendering)%26%26((r%3Dn.debounceRendering)%7C%7Ct)(_)%7Dfunction%20_()%7Bfor(var%20n%3Bi%3Du.length%3B)n%3Du.sort(function(n%2Cl)%7Breturn%20n.__v.__b-l.__v.__b%7D)%2Cu%3D%5B%5D%2Cn.some(function(n)%7Bvar%20l%2Cu%2Ci%2Ct%2Cr%2Co%2Cf%3Bn.__d%26%26(o%3D(r%3D(l%3Dn).__v).__e%2C(f%3Dl.__P)%26%26(u%3D%5B%5D%2C(i%3Da(%7B%7D%2Cr)).__v%3Di%2Ct%3DA(f%2Cr%2Ci%2Cl.__n%2Cvoid%200!%3D%3Df.ownerSVGElement%2Cnull%2Cu%2Cnull%3D%3Do%3Fw(r)%3Ao)%2CT(u%2Cr)%2Ct!%3Do%26%26k(r)))%7D)%7Dfunction%20b(n%2Cl%2Cu%2Ci%2Ct%2Cr%2Co%2Cf%2Cs)%7Bvar%20a%2Ch%2Cp%2Cy%2Cd%2Cm%2Ck%2Cg%3Du%26%26u.__k%7C%7Cc%2C_%3Dg.length%3Bif(f%3D%3De%26%26(f%3Dnull!%3Dr%3Fr%5B0%5D%3A_%3Fw(u%2C0)%3Anull)%2Ca%3D0%2Cl.__k%3Dx(l.__k%2Cfunction(u)%7Bif(null!%3Du)%7Bif(u.__%3Dl%2Cu.__b%3Dl.__b%2B1%2Cnull%3D%3D%3D(p%3Dg%5Ba%5D)%7C%7Cp%26%26u.key%3D%3Dp.key%26%26u.type%3D%3D%3Dp.type)g%5Ba%5D%3Dvoid%200%3Belse%20for(h%3D0%3Bh%3C_%3Bh%2B%2B)%7Bif((p%3Dg%5Bh%5D)%26%26u.key%3D%3Dp.key%26%26u.type%3D%3D%3Dp.type)%7Bg%5Bh%5D%3Dvoid%200%3Bbreak%7Dp%3Dnull%7Dif(y%3DA(n%2Cu%2Cp%3Dp%7C%7Ce%2Ci%2Ct%2Cr%2Co%2Cf%2Cs)%2C(h%3Du.ref)%26%26p.ref!%3Dh%26%26(k%7C%7C(k%3D%5B%5D)%2Cp.ref%26%26k.push(p.ref%2Cnull%2Cu)%2Ck.push(h%2Cu.__c%7C%7Cy%2Cu))%2Cnull!%3Dy)%7Bvar%20c%3Bif(null%3D%3Dm%26%26(m%3Dy)%2Cvoid%200!%3D%3Du.__d)c%3Du.__d%2Cu.__d%3Dvoid%200%3Belse%20if(r%3D%3Dp%7C%7Cy!%3Df%7C%7Cnull%3D%3Dy.parentNode)%7Bn%3Aif(null%3D%3Df%7C%7Cf.parentNode!%3D%3Dn)n.appendChild(y)%2Cc%3Dnull%3Belse%7Bfor(d%3Df%2Ch%3D0%3B(d%3Dd.nextSibling)%26%26h%3C_%3Bh%2B%3D2)if(d%3D%3Dy)break%20n%3Bn.insertBefore(y%2Cf)%2Cc%3Df%7D%5C%22option%5C%22%3D%3Dl.type%26%26(n.value%3D%5C%22%5C%22)%7Df%3Dvoid%200!%3D%3Dc%3Fc%3Ay.nextSibling%2C%5C%22function%5C%22%3D%3Dtypeof%20l.type%26%26(l.__d%3Df)%7Delse%20f%26%26p.__e%3D%3Df%26%26f.parentNode!%3Dn%26%26(f%3Dw(p))%7Dreturn%20a%2B%2B%2Cu%7D)%2Cl.__e%3Dm%2Cnull!%3Dr%26%26%5C%22function%5C%22!%3Dtypeof%20l.type)for(a%3Dr.length%3Ba--%3B)null!%3Dr%5Ba%5D%26%26v(r%5Ba%5D)%3Bfor(a%3D_%3Ba--%3B)null!%3Dg%5Ba%5D%26%26D(g%5Ba%5D%2Cg%5Ba%5D)%3Bif(k)for(a%3D0%3Ba%3Ck.length%3Ba%2B%2B)j(k%5Ba%5D%2Ck%5B%2B%2Ba%5D%2Ck%5B%2B%2Ba%5D)%7Dfunction%20x(n%2Cl%2Cu)%7Bif(null%3D%3Du%26%26(u%3D%5B%5D)%2Cnull%3D%3Dn%7C%7C%5C%22boolean%5C%22%3D%3Dtypeof%20n)l%26%26u.push(l(null))%3Belse%20if(Array.isArray(n))for(var%20i%3D0%3Bi%3Cn.length%3Bi%2B%2B)x(n%5Bi%5D%2Cl%2Cu)%3Belse%20u.push(l%3Fl(%5C%22string%5C%22%3D%3Dtypeof%20n%7C%7C%5C%22number%5C%22%3D%3Dtypeof%20n%3Fp(null%2Cn%2Cnull%2Cnull%2Cn)%3Anull!%3Dn.__e%7C%7Cnull!%3Dn.__c%3Fp(n.type%2Cn.props%2Cn.key%2Cnull%2Cn.__v)%3An)%3An)%3Breturn%20u%7Dfunction%20P(n%2Cl%2Cu%2Ci%2Ct)%7Bvar%20r%3Bfor(r%20in%20u)%5C%22children%5C%22%3D%3D%3Dr%7C%7C%5C%22key%5C%22%3D%3D%3Dr%7C%7Cr%20in%20l%7C%7CN(n%2Cr%2Cnull%2Cu%5Br%5D%2Ci)%3Bfor(r%20in%20l)t%26%26%5C%22function%5C%22!%3Dtypeof%20l%5Br%5D%7C%7C%5C%22children%5C%22%3D%3D%3Dr%7C%7C%5C%22key%5C%22%3D%3D%3Dr%7C%7C%5C%22value%5C%22%3D%3D%3Dr%7C%7C%5C%22checked%5C%22%3D%3D%3Dr%7C%7Cu%5Br%5D%3D%3D%3Dl%5Br%5D%7C%7CN(n%2Cr%2Cl%5Br%5D%2Cu%5Br%5D%2Ci)%7Dfunction%20C(n%2Cl%2Cu)%7B%5C%22-%5C%22%3D%3D%3Dl%5B0%5D%3Fn.setProperty(l%2Cu)%3An%5Bl%5D%3D%5C%22number%5C%22%3D%3Dtypeof%20u%26%26!1%3D%3D%3Ds.test(l)%3Fu%2B%5C%22px%5C%22%3Anull%3D%3Du%3F%5C%22%5C%22%3Au%7Dfunction%20N(n%2Cl%2Cu%2Ci%2Ct)%7Bvar%20r%2Co%2Cf%2Ce%2Cc%3Bif(t%3F%5C%22className%5C%22%3D%3D%3Dl%26%26(l%3D%5C%22class%5C%22)%3A%5C%22class%5C%22%3D%3D%3Dl%26%26(l%3D%5C%22className%5C%22)%2C%5C%22style%5C%22%3D%3D%3Dl)if(r%3Dn.style%2C%5C%22string%5C%22%3D%3Dtypeof%20u)r.cssText%3Du%3Belse%7Bif(%5C%22string%5C%22%3D%3Dtypeof%20i%26%26(r.cssText%3D%5C%22%5C%22%2Ci%3Dnull)%2Ci)for(e%20in%20i)u%26%26e%20in%20u%7C%7CC(r%2Ce%2C%5C%22%5C%22)%3Bif(u)for(c%20in%20u)i%26%26u%5Bc%5D%3D%3D%3Di%5Bc%5D%7C%7CC(r%2Cc%2Cu%5Bc%5D)%7Delse%5C%22o%5C%22%3D%3D%3Dl%5B0%5D%26%26%5C%22n%5C%22%3D%3D%3Dl%5B1%5D%3F(o%3Dl!%3D%3D(l%3Dl.replace(%2FCapture%24%2F%2C%5C%22%5C%22))%2Cf%3Dl.toLowerCase()%2Cl%3D(f%20in%20n%3Ff%3Al).slice(2)%2Cu%3F(i%7C%7Cn.addEventListener(l%2Cz%2Co)%2C(n.l%7C%7C(n.l%3D%7B%7D))%5Bl%5D%3Du)%3An.removeEventListener(l%2Cz%2Co))%3A%5C%22list%5C%22!%3D%3Dl%26%26%5C%22tagName%5C%22!%3D%3Dl%26%26%5C%22form%5C%22!%3D%3Dl%26%26%5C%22type%5C%22!%3D%3Dl%26%26%5C%22size%5C%22!%3D%3Dl%26%26!t%26%26l%20in%20n%3Fn%5Bl%5D%3Dnull%3D%3Du%3F%5C%22%5C%22%3Au%3A%5C%22function%5C%22!%3Dtypeof%20u%26%26%5C%22dangerouslySetInnerHTML%5C%22!%3D%3Dl%26%26(l!%3D%3D(l%3Dl.replace(%2F%5Exlink%3A%3F%2F%2C%5C%22%5C%22))%3Fnull%3D%3Du%7C%7C!1%3D%3D%3Du%3Fn.removeAttributeNS(%5C%22http%3A%2F%2Fwww.w3.org%2F1999%2Fxlink%5C%22%2Cl.toLowerCase())%3An.setAttributeNS(%5C%22http%3A%2F%2Fwww.w3.org%2F1999%2Fxlink%5C%22%2Cl.toLowerCase()%2Cu)%3Anull%3D%3Du%7C%7C!1%3D%3D%3Du%26%26!%2F%5Ear%2F.test(l)%3Fn.removeAttribute(l)%3An.setAttribute(l%2Cu))%7Dfunction%20z(l)%7Bthis.l%5Bl.type%5D(n.event%3Fn.event(l)%3Al)%7Dfunction%20A(l%2Cu%2Ci%2Ct%2Cr%2Co%2Cf%2Ce%2Cc)%7Bvar%20s%2Cv%2Ch%2Cp%2Cy%2Cw%2Ck%2Cg%2C_%2Cx%2CP%3Du.type%3Bif(void%200!%3D%3Du.constructor)return%20null%3B(s%3Dn.__b)%26%26s(u)%3Btry%7Bn%3Aif(%5C%22function%5C%22%3D%3Dtypeof%20P)%7Bif(g%3Du.props%2C_%3D(s%3DP.contextType)%26%26t%5Bs.__c%5D%2Cx%3Ds%3F_%3F_.props.value%3As.__%3At%2Ci.__c%3Fk%3D(v%3Du.__c%3Di.__c).__%3Dv.__E%3A(%5C%22prototype%5C%22in%20P%26%26P.prototype.render%3Fu.__c%3Dv%3Dnew%20P(g%2Cx)%3A(u.__c%3Dv%3Dnew%20m(g%2Cx)%2Cv.constructor%3DP%2Cv.render%3DE)%2C_%26%26_.sub(v)%2Cv.props%3Dg%2Cv.state%7C%7C(v.state%3D%7B%7D)%2Cv.context%3Dx%2Cv.__n%3Dt%2Ch%3Dv.__d%3D!0%2Cv.__h%3D%5B%5D)%2Cnull%3D%3Dv.__s%26%26(v.__s%3Dv.state)%2Cnull!%3DP.getDerivedStateFromProps%26%26(v.__s%3D%3Dv.state%26%26(v.__s%3Da(%7B%7D%2Cv.__s))%2Ca(v.__s%2CP.getDerivedStateFromProps(g%2Cv.__s)))%2Cp%3Dv.props%2Cy%3Dv.state%2Ch)null%3D%3DP.getDerivedStateFromProps%26%26null!%3Dv.componentWillMount%26%26v.componentWillMount()%2Cnull!%3Dv.componentDidMount%26%26v.__h.push(v.componentDidMount)%3Belse%7Bif(null%3D%3DP.getDerivedStateFromProps%26%26g!%3D%3Dp%26%26null!%3Dv.componentWillReceiveProps%26%26v.componentWillReceiveProps(g%2Cx)%2C!v.__e%26%26null!%3Dv.shouldComponentUpdate%26%26!1%3D%3D%3Dv.shouldComponentUpdate(g%2Cv.__s%2Cx)%7C%7Cu.__v%3D%3D%3Di.__v%26%26!v.__)%7Bfor(v.props%3Dg%2Cv.state%3Dv.__s%2Cu.__v!%3D%3Di.__v%26%26(v.__d%3D!1)%2Cv.__v%3Du%2Cu.__e%3Di.__e%2Cu.__k%3Di.__k%2Cv.__h.length%26%26f.push(v)%2Cs%3D0%3Bs%3Cu.__k.length%3Bs%2B%2B)u.__k%5Bs%5D%26%26(u.__k%5Bs%5D.__%3Du)%3Bbreak%20n%7Dnull!%3Dv.componentWillUpdate%26%26v.componentWillUpdate(g%2Cv.__s%2Cx)%2Cnull!%3Dv.componentDidUpdate%26%26v.__h.push(function()%7Bv.componentDidUpdate(p%2Cy%2Cw)%7D)%7Dv.context%3Dx%2Cv.props%3Dg%2Cv.state%3Dv.__s%2C(s%3Dn.__r)%26%26s(u)%2Cv.__d%3D!1%2Cv.__v%3Du%2Cv.__P%3Dl%2Cs%3Dv.render(v.props%2Cv.state%2Cv.context)%2Cu.__k%3Dnull!%3Ds%26%26s.type%3D%3Dd%26%26null%3D%3Ds.key%3Fs.props.children%3AArray.isArray(s)%3Fs%3A%5Bs%5D%2Cnull!%3Dv.getChildContext%26%26(t%3Da(a(%7B%7D%2Ct)%2Cv.getChildContext()))%2Ch%7C%7Cnull%3D%3Dv.getSnapshotBeforeUpdate%7C%7C(w%3Dv.getSnapshotBeforeUpdate(p%2Cy))%2Cb(l%2Cu%2Ci%2Ct%2Cr%2Co%2Cf%2Ce%2Cc)%2Cv.base%3Du.__e%2Cv.__h.length%26%26f.push(v)%2Ck%26%26(v.__E%3Dv.__%3Dnull)%2Cv.__e%3D!1%7Delse%20null%3D%3Do%26%26u.__v%3D%3D%3Di.__v%3F(u.__k%3Di.__k%2Cu.__e%3Di.__e)%3Au.__e%3D%24(i.__e%2Cu%2Ci%2Ct%2Cr%2Co%2Cf%2Cc)%3B(s%3Dn.diffed)%26%26s(u)%7Dcatch(l)%7Bu.__v%3Dnull%2Cn.__e(l%2Cu%2Ci)%7Dreturn%20u.__e%7Dfunction%20T(l%2Cu)%7Bn.__c%26%26n.__c(u%2Cl)%2Cl.some(function(u)%7Btry%7Bl%3Du.__h%2Cu.__h%3D%5B%5D%2Cl.some(function(n)%7Bn.call(u)%7D)%7Dcatch(l)%7Bn.__e(l%2Cu.__v)%7D%7D)%7Dfunction%20%24(n%2Cl%2Cu%2Ci%2Ct%2Cr%2Co%2Cf)%7Bvar%20s%2Ca%2Cv%2Ch%2Cp%2Cy%3Du.props%2Cd%3Dl.props%3Bif(t%3D%5C%22svg%5C%22%3D%3D%3Dl.type%7C%7Ct%2Cnull!%3Dr)for(s%3D0%3Bs%3Cr.length%3Bs%2B%2B)if(null!%3D(a%3Dr%5Bs%5D)%26%26((null%3D%3D%3Dl.type%3F3%3D%3D%3Da.nodeType%3Aa.localName%3D%3D%3Dl.type)%7C%7Cn%3D%3Da))%7Bn%3Da%2Cr%5Bs%5D%3Dnull%3Bbreak%7Dif(null%3D%3Dn)%7Bif(null%3D%3D%3Dl.type)return%20document.createTextNode(d)%3Bn%3Dt%3Fdocument.createElementNS(%5C%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%5C%22%2Cl.type)%3Adocument.createElement(l.type%2Cd.is%26%26%7Bis%3Ad.is%7D)%2Cr%3Dnull%2Cf%3D!1%7Dif(null%3D%3D%3Dl.type)y!%3D%3Dd%26%26n.data!%3Dd%26%26(n.data%3Dd)%3Belse%7Bif(null!%3Dr%26%26(r%3Dc.slice.call(n.childNodes))%2Cv%3D(y%3Du.props%7C%7Ce).dangerouslySetInnerHTML%2Ch%3Dd.dangerouslySetInnerHTML%2C!f)%7Bif(y%3D%3D%3De)for(y%3D%7B%7D%2Cp%3D0%3Bp%3Cn.attributes.length%3Bp%2B%2B)y%5Bn.attributes%5Bp%5D.name%5D%3Dn.attributes%5Bp%5D.value%3B(h%7C%7Cv)%26%26(h%26%26v%26%26h.__html%3D%3Dv.__html%7C%7C(n.innerHTML%3Dh%26%26h.__html%7C%7C%5C%22%5C%22))%7DP(n%2Cd%2Cy%2Ct%2Cf)%2Ch%3Fl.__k%3D%5B%5D%3A(l.__k%3Dl.props.children%2Cb(n%2Cl%2Cu%2Ci%2C%5C%22foreignObject%5C%22!%3D%3Dl.type%26%26t%2Cr%2Co%2Ce%2Cf))%2Cf%7C%7C(%5C%22value%5C%22in%20d%26%26void%200!%3D%3D(s%3Dd.value)%26%26s!%3D%3Dn.value%26%26N(n%2C%5C%22value%5C%22%2Cs%2Cy.value%2C!1)%2C%5C%22checked%5C%22in%20d%26%26void%200!%3D%3D(s%3Dd.checked)%26%26s!%3D%3Dn.checked%26%26N(n%2C%5C%22checked%5C%22%2Cs%2Cy.checked%2C!1))%7Dreturn%20n%7Dfunction%20j(l%2Cu%2Ci)%7Btry%7B%5C%22function%5C%22%3D%3Dtypeof%20l%3Fl(u)%3Al.current%3Du%7Dcatch(l)%7Bn.__e(l%2Ci)%7D%7Dfunction%20D(l%2Cu%2Ci)%7Bvar%20t%2Cr%2Co%3Bif(n.unmount%26%26n.unmount(l)%2C(t%3Dl.ref)%26%26(t.current%26%26t.current!%3D%3Dl.__e%7C%7Cj(t%2Cnull%2Cu))%2Ci%7C%7C%5C%22function%5C%22%3D%3Dtypeof%20l.type%7C%7C(i%3Dnull!%3D(r%3Dl.__e))%2Cl.__e%3Dl.__d%3Dvoid%200%2Cnull!%3D(t%3Dl.__c))%7Bif(t.componentWillUnmount)try%7Bt.componentWillUnmount()%7Dcatch(l)%7Bn.__e(l%2Cu)%7Dt.base%3Dt.__P%3Dnull%7Dif(t%3Dl.__k)for(o%3D0%3Bo%3Ct.length%3Bo%2B%2B)t%5Bo%5D%26%26D(t%5Bo%5D%2Cu%2Ci)%3Bnull!%3Dr%26%26v(r)%7Dfunction%20E(n%2Cl%2Cu)%7Breturn%20this.constructor(n%2Cu)%7Dfunction%20H(l%2Cu%2Ci)%7Bvar%20t%2Cr%2Cf%3Bn.__%26%26n.__(l%2Cu)%2Cr%3D(t%3Di%3D%3D%3Do)%3Fnull%3Ai%26%26i.__k%7C%7Cu.__k%2Cl%3Dh(d%2Cnull%2C%5Bl%5D)%2Cf%3D%5B%5D%2CA(u%2C(t%3Fu%3Ai%7C%7Cu).__k%3Dl%2Cr%7C%7Ce%2Ce%2Cvoid%200!%3D%3Du.ownerSVGElement%2Ci%26%26!t%3F%5Bi%5D%3Ar%3Fnull%3Ac.slice.call(u.childNodes)%2Cf%2Ci%7C%7Ce%2Ct)%2CT(f%2Cl)%7Dfunction%20I(n%2Cl)%7BH(n%2Cl%2Co)%7Dfunction%20L(n%2Cl)%7Bvar%20u%2Ci%3Bfor(i%20in%20l%3Da(a(%7B%7D%2Cn.props)%2Cl)%2Carguments.length%3E2%26%26(l.children%3Dc.slice.call(arguments%2C2))%2Cu%3D%7B%7D%2Cl)%5C%22key%5C%22!%3D%3Di%26%26%5C%22ref%5C%22!%3D%3Di%26%26(u%5Bi%5D%3Dl%5Bi%5D)%3Breturn%20p(n.type%2Cu%2Cl.key%7C%7Cn.key%2Cl.ref%7C%7Cn.ref%2Cnull)%7Dfunction%20M(n)%7Bvar%20l%3D%7B%7D%2Cu%3D%7B__c%3A%5C%22__cC%5C%22%2Bf%2B%2B%2C__%3An%2CConsumer%3Afunction(n%2Cl)%7Breturn%20n.children(l)%7D%2CProvider%3Afunction(n)%7Bvar%20i%2Ct%3Dthis%3Breturn%20this.getChildContext%7C%7C(i%3D%5B%5D%2Cthis.getChildContext%3Dfunction()%7Breturn%20l%5Bu.__c%5D%3Dt%2Cl%7D%2Cthis.shouldComponentUpdate%3Dfunction(n)%7Bt.props.value!%3D%3Dn.value%26%26i.some(function(l)%7Bl.context%3Dn.value%2Cg(l)%7D)%7D%2Cthis.sub%3Dfunction(n)%7Bi.push(n)%3Bvar%20l%3Dn.componentWillUnmount%3Bn.componentWillUnmount%3Dfunction()%7Bi.splice(i.indexOf(n)%2C1)%2Cl%26%26l.call(n)%7D%7D)%2Cn.children%7D%7D%3Breturn%20u.Consumer.contextType%3Du%2Cu.Provider.__%3Du%2Cu%7Dn%3D%7B__e%3Afunction(n%2Cl)%7Bfor(var%20u%2Ci%3Bl%3Dl.__%3B)if((u%3Dl.__c)%26%26!u.__)try%7Bif(u.constructor%26%26null!%3Du.constructor.getDerivedStateFromError%26%26(i%3D!0%2Cu.setState(u.constructor.getDerivedStateFromError(n)))%2Cnull!%3Du.componentDidCatch%26%26(i%3D!0%2Cu.componentDidCatch(n))%2Ci)return%20g(u.__E%3Du)%7Dcatch(l)%7Bn%3Dl%7Dthrow%20n%7D%7D%2Cl%3Dfunction(n)%7Breturn%20null!%3Dn%26%26void%200%3D%3D%3Dn.constructor%7D%2Cm.prototype.setState%3Dfunction(n%2Cl)%7Bvar%20u%3Bu%3Dthis.__s!%3D%3Dthis.state%3Fthis.__s%3Athis.__s%3Da(%7B%7D%2Cthis.state)%2C%5C%22function%5C%22%3D%3Dtypeof%20n%26%26(n%3Dn(u%2Cthis.props))%2Cn%26%26a(u%2Cn)%2Cnull!%3Dn%26%26this.__v%26%26(l%26%26this.__h.push(l)%2Cg(this))%7D%2Cm.prototype.forceUpdate%3Dfunction(n)%7Bthis.__v%26%26(this.__e%3D!0%2Cn%26%26this.__h.push(n)%2Cg(this))%7D%2Cm.prototype.render%3Dd%2Cu%3D%5B%5D%2Ci%3D0%2Ct%3D%5C%22function%5C%22%3D%3Dtypeof%20Promise%3FPromise.prototype.then.bind(Promise.resolve())%3AsetTimeout%2Co%3De%2Cf%3D0%3Bexport%7BH%20as%20render%2CI%20as%20hydrate%2Ch%20as%20createElement%2Ch%2Cd%20as%20Fragment%2Cy%20as%20createRef%2Cl%20as%20isValidElement%2Cm%20as%20Component%2CL%20as%20cloneElement%2CM%20as%20createContext%2Cx%20as%20toChildArray%2CD%20as%20_unmount%2Cn%20as%20options%7D%3B%22%2C%22isEntry%22%3Atrue%7D%5D%2C%22options%22%3A%7B%22format%22%3A%22es%22%2C%22name%22%3A%22myBundle%22%2C%22amd%22%3A%7B%22id%22%3A%22%22%7D%2C%22globals%22%3A%7B%7D%7D%2C%22example%22%3Anull%7D

Feature Proposal

It should be possible to disable this ASI when no source transformations have taken place to that code.

A simpler starting heuristic could also be to just disable ASI entirely when treeshaking: false is used.

@guybedford
Copy link
Contributor Author

guybedford commented May 9, 2020

Unfortunately it seems the Preact example is breaking the repl request length :)

It can be seen by copying this source though - https://unpkg.com/preact@10.4.1/dist/preact.module.js.

@lukastaegert
Copy link
Member

This ASI makes things a lot easier as there are many edge cases where "untouched code" borders on other modules or modified code that we do no need to handle explicitly here. Avoiding this will also not provide any structural code improvements but rather just some syntactic optimization. If people are interested in this minimal gain, I would rather expect them to use a minifier to handle this. For Rollup, this will just introduce complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants