New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace reexports + code split result in variable conflict imports #3741

Closed

manucorporat opened this issue Aug 21, 2020 · 1 comment · Fixed by #3742

Labels

Contributor

manucorporat commented Aug 21, 2020 •

edited

Rollup Version:2.26.4
Operating System (or Browser):
Node Version (if applicable):
Link to reproduction (IMPORTANT, read below):

https://rollupjs.org/repl/?version=2.26.4&shareable=JTdCJTIybW9kdWxlcyUyMiUzQSU1QiU3QiUyMm5hbWUlMjIlM0ElMjJtYWluLmpzJTIyJTJDJTIyY29kZSUyMiUzQSUyMmltcG9ydCUyMColMjBhcyUyMG1vZCUyMGZyb20lMjAnLiUyRmluZGV4LmpzJyUzQiU1Q25jb25zb2xlLmxvZyhtb2QpJTNCJTIyJTJDJTIyaXNFbnRyeSUyMiUzQXRydWUlN0QlMkMlN0IlMjJuYW1lJTIyJTNBJTIyaW5kZXguanMlMjIlMkMlMjJjb2RlJTIyJTNBJTIyZXhwb3J0JTIwKiUyMGFzJTIwdm9sdW1lJTIwZnJvbSUyMCU1QyUyMi4lMkZ2b2x1bWUlNUMlMjIlM0IlNUNuZXhwb3J0JTIwKiUyMGFzJTIwZ2VvbWV0cnklMjBmcm9tJTIwJTVDJTIyLiUyRmdlb21ldHJ5JTVDJTIyJTNCJTVDbmV4cG9ydCUyMColMjBhcyUyMHN0b3JhZ2UlMjBmcm9tJTIwJTVDJTIyLiUyRnN0b3JhZ2UlNUMlMjIlM0IlNUNuJTIyJTJDJTIyaXNFbnRyeSUyMiUzQWZhbHNlJTdEJTJDJTdCJTIybmFtZSUyMiUzQSUyMnZvbHVtZS5qcyUyMiUyQyUyMmNvZGUlMjIlM0ElMjJleHBvcnQlMjBjb25zdCUyMGZvbyUyMCUzRCUyMCgpJTIwJTNEJTNFJTIwJTdCJTIwY29uc29sZS5sb2coJ2ZvbycpJTNCJTIwJTdEJTNCJTVDbmV4cG9ydCUyMGNvbnN0JTIwYmFyJTIwJTNEJTIwKCklMjAlM0QlM0UlMjAlN0IlMjBjb25zb2xlLmxvZygnZm9vJyklM0IlMjAlN0QlM0IlNUNuZXhwb3J0JTIwY29uc3QlMjB0aGluZyUyMCUzRCUyMCgpJTIwJTNEJTNFJTIwJTdCJTIwY29uc29sZS5sb2coJ2ZvbycpJTNCJTIwJTdEJTNCJTIyJTJDJTIyaXNFbnRyeSUyMiUzQWZhbHNlJTdEJTJDJTdCJTIybmFtZSUyMiUzQSUyMmdlb21ldHJ5LmpzJTIyJTJDJTIyY29kZSUyMiUzQSUyMmV4cG9ydCUyMGNvbnN0JTIwZm9vJTIwJTNEJTIwKCklMjAlM0QlM0UlMjAlN0IlMjBjb25zb2xlLmxvZygnZm9vJyklM0IlMjAlN0QlM0IlNUNuZXhwb3J0JTIwY29uc3QlMjBiYXIlMjAlM0QlMjAoKSUyMCUzRCUzRSUyMCU3QiUyMGNvbnNvbGUubG9nKCdmb28nKSUzQiUyMCU3RCUzQiU1Q25leHBvcnQlMjBjb25zdCUyMHRoaW5nJTIwJTNEJTIwKCklMjAlM0QlM0UlMjAlN0IlMjBjb25zb2xlLmxvZygnZm9vJyklM0IlMjAlN0QlM0IlMjIlN0QlMkMlN0IlMjJuYW1lJTIyJTNBJTIyc3RvcmFnZS5qcyUyMiUyQyUyMmNvZGUlMjIlM0ElMjJleHBvcnQlMjBjb25zdCUyMGZvbyUyMCUzRCUyMCgpJTIwJTNEJTNFJTIwJTdCJTIwY29uc29sZS5sb2coJ2ZvbycpJTNCJTIwJTdEJTNCJTVDbmV4cG9ydCUyMGNvbnN0JTIwYmFyJTIwJTNEJTIwKCklMjAlM0QlM0UlMjAlN0IlMjBjb25zb2xlLmxvZygnZm9vJyklM0IlMjAlN0QlM0IlNUNuZXhwb3J0JTIwY29uc3QlMjB0aGluZyUyMCUzRCUyMCgpJTIwJTNEJTNFJTIwJTdCJTIwY29uc29sZS5sb2coJ2ZvbycpJTNCJTIwJTdEJTNCJTIyJTdEJTJDJTdCJTIybmFtZSUyMiUzQSUyMm1vZHVsZV8zLmpzJTIyJTJDJTIyY29kZSUyMiUzQSUyMmltcG9ydCUyMCU3QmZvbyU3RCUyMGZyb20lMjAnLiUyRnN0b3JhZ2UuanMnJTNCJTVDbmltcG9ydCUyMCU3QmJhciU3RCUyMGZyb20lMjAnLiUyRmdlb21ldHJ5LmpzJyUzQiU1Q25pbXBvcnQlMjAlN0J0aGluZyU3RCUyMGZyb20lMjAnLiUyRnZvbHVtZS5qcyclM0IlNUNuJTVDbmNvbnNvbGUubG9nKGZvbyUyQyUyMGJhciUyQyUyMHRoaW5nKSUzQiUyMiUyQyUyMmlzRW50cnklMjIlM0F0cnVlJTdEJTVEJTJDJTIyb3B0aW9ucyUyMiUzQSU3QiUyMmZvcm1hdCUyMiUzQSUyMmVzJTIyJTJDJTIybmFtZSUyMiUzQSUyMm15QnVuZGxlJTIyJTJDJTIyYW1kJTIyJTNBJTdCJTIyaWQlMjIlM0ElMjIlMjIlN0QlMkMlMjJnbG9iYWxzJTIyJTNBJTdCJTdEJTdEJTJDJTIyZXhhbXBsZSUyMiUzQW51bGwlN0Q=

Expected Behavior

The generated import statemente, should not contain variable name conflicts.

import { v as geometry, g as storage, s as volume } from './storage-f1acf145.js';

Actual Behavior

The generated import includes conflictive variable declarations, not pointing to the actual exports:

import { v as storage, g as storage, s as storage } from './storage-f1acf145.js';

lukastaegert added the t¹ 🐞 bug label

lukastaegert mentioned this issue

Avoid variable name conflict when reexporting several namespaces from a chunk #3742

Merged

9 tasks

Member

lukastaegert commented Aug 22, 2020

Thanks for spotting, this was stupid. Fix at #3742.

lukastaegert closed this as completed in #3742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment