Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser sourcemap #3990

Merged
merged 1 commit into from Mar 11, 2021
Merged

Add browser sourcemap #3990

merged 1 commit into from Mar 11, 2021

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Apparently people are using the REPL to actually debug Rollup issues. Which is a good thing, therefore this is including specifically the source map of the browser bundle in the package.
Also it removes a left-over log statement.

@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#include-browser-sourcemap

or load it into the REPL:
https://rollupjs.org/repl/?circleci=14492

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #3990 (c0f7ea2) into master (a692a8d) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3990      +/-   ##
==========================================
- Coverage   97.22%   97.22%   -0.01%     
==========================================
  Files         191      191              
  Lines        6732     6731       -1     
  Branches     1970     1970              
==========================================
- Hits         6545     6544       -1     
  Misses         99       99              
  Partials       88       88              
Impacted Files Coverage Δ
src/Module.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a692a8d...c0f7ea2. Read the comment docs.

@lukastaegert lukastaegert merged commit cf3329c into master Mar 11, 2021
@lukastaegert lukastaegert deleted the include-browser-sourcemap branch March 11, 2021 04:47
This was referenced Mar 11, 2021
This was referenced Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants