Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @jridgewell/sourcemap-codec #4785

Merged
merged 1 commit into from Jan 5, 2023
Merged

Use @jridgewell/sourcemap-codec #4785

merged 1 commit into from Jan 5, 2023

Conversation

bluwy
Copy link
Contributor

@bluwy bluwy commented Jan 3, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

none

Description

The sourcemap-codec package has been deprecated in favour of jridgewell/sourcemap-codec, which provides extra perf optimizations. The API is interchangable so it's a matter of renaming the imports.

Though Rollup only uses the decode API, and there's only slight decode perf, I think it's still worth the change.

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #4785 (09bcf36) into master (dce233b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4785   +/-   ##
=======================================
  Coverage   99.03%   99.03%           
=======================================
  Files         217      217           
  Lines        7773     7773           
  Branches     2158     2158           
=======================================
  Hits         7698     7698           
  Misses         24       24           
  Partials       51       51           
Impacted Files Coverage Δ
src/utils/decodedSourcemap.ts 85.71% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@lukastaegert lukastaegert merged commit 6a29327 into rollup:master Jan 5, 2023
@bluwy bluwy deleted the use-jridgewell-sourcemap-codec branch January 5, 2023 07:03
@lukastaegert
Copy link
Member

This PR has been released as part of rollup@3.10.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants