Support legal file names with a dollar notation like $.js or a$.js

[aleen42]

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

List any relevant issue numbers:

Description

Hope not to sanitize file names like $.js, or a$.js which is legal in all OS systems.

[lukastaegert]

legal in all OS systems

Others disagree: https://www.mtu.edu/umc/services/websites/writing/characters-avoid/

Why does everyone make PRs to change the defaults instead of passing your own sanitizer function via config?

[aleen42]

@lukastaegert at least I have tested under Windows, Linux, and Linux-based MacOS. $ may be a common signature in a file name, and I think it is better to allow it as a default behaviour, rather than making everyone disable sanitiser or setting a filter. Especially when meeting some developers trying to migrate setting from Webpack to Rollup. It is strange behaviour that everyone needs to trace where the name is changed by someone.

[lukastaegert]

https://rollupjs.org/guide/en/#outputsanitizefilename

[lukastaegert]

And there are very good reasons not to have $ in a file name under MacOS and Linux, namely accidental environment variable interpolation in scripts. But settings the above option to false should fix everything.

[aleen42]

@lukastaegert I knew the option. But environment variables only take effect when naming with $x, it is safe for $ only and x$, and I think it will be smarter when handling these two situations:

touch $.js # OK in MacOS
touch x$.js # OK in MacOS
touch $x.js # not OK