Plugin throwing Error with numeric code causes TypeError within Rollup itself

[nolanlawson]

Rollup Version

3.25.1

Operating System (or Browser)

MacOS

Node Version (if applicable)

16

Link To Reproduction

https://stackblitz.com/edit/rollup-repro-hc1mbx?file=rollup.config.js

Expected Behaviour

When a plugin throws an error with a numeric code, like so:

transform() {
  const error = new Error();
  error.code = 1234;
  throw error;
},

... I would expect this to go through the normal Rollup plugin error reporting process.

Actual Behaviour

An error is thrown from within Rollup itself:

TypeError: error.code.startsWith is not a function

This error comes from this line of code:

rollup/src/utils/logs.ts

Line 790 in 63b7125

if (error.code && !error.code.startsWith('PLUGIN_') && !error.pluginCode) {

...and seems to have been introduced in 23c111c (Rollup v3.25.0).

The assumption seems to be that, if error.code is truthy, then it's a string type. However, a plugin may throw an Error with a numeric type for error.code.

[TrickyPi]

For customized errors in Plugin, I personally recommend using this.error api with type hints, it will tell us that Rollup expects code to be of type string.

[nolanlawson]

@TrickyPi That's totally reasonable, but unless I wrap everything in my plugin in a try/catch, I cannot be sure that I don't have some deep dependency that is throwing an Error with a numeric code.

[TrickyPi]

Hmm, fair enough.

[lukastaegert]

Yes, definitely an oversight. Unfortunately as I am travelling at the moment, fixing it will require at least another week.

[rollup-bot]

This issue has been resolved via #5042 as part of rollup@3.25.2. You can test it via npm install rollup.