Add forceExit CLI flag
#5195
Merged
Add forceExit CLI flag
#5195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lukastaegert
approved these changes
Oct 14, 2023
Codecov Report
@@ Coverage Diff @@
## master #5195 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 231 231
Lines 8861 8863 +2
Branches 2316 2317 +1
=======================================
+ Hits 8756 8758 +2
Misses 44 44
Partials 61 61
|
|
Ah, but we would need a test. It should not be difficult to add one to |
auto-merge was automatically disabled
October 17, 2023 17:20
Head branch was pushed to by a user without write access
lukastaegert
approved these changes
Nov 3, 2023
|
This PR has been released as part of rollup@4.3.0. You can test it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This adds a new
forceExitCLI flag which implements the core behaviour of #4969 (exit the process once Rollup is done even if there are still open handles or pending operations). Currently it doesn't implement the behaviour for watch mode but that should be trivial to add if desired.