fix: prevent ENOENT error on temp config removal
#5198
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
While I do not know why you have these issues (is some parallel process removing files?) I have no issues swallowing errors here. But I do not understand why you need the non-promise unlink function for this, and I do not like it as it is inconsistent.
You can also "safely eat errors" by either awaiting and writing it in a try-catch with empty handler, or append a .catch(doNothing).
Though I would actually feel better if we would still show a warning in that case as that points to an issue with your build system.
|
@lukastaegert thanks for the initial review. We are using Lerna which by default parallelizes scripting tasks across monorepo packages. I was concerned about But if we think that is the right way to go, that's totally fine with me. I'll update with a try..catch warning. |
|
@lukastaegert do you think we have something acceptable for merge here? Thank you 🙏 |
Codecov Report
@@ Coverage Diff @@
## master #5198 +/- ##
==========================================
- Coverage 98.81% 98.79% -0.03%
==========================================
Files 231 231
Lines 8863 8866 +3
Branches 2317 2318 +1
==========================================
+ Hits 8758 8759 +1
- Misses 44 46 +2
Partials 61 61
|
|
This PR has been released as part of rollup@4.3.0. You can test it via |
This PR contains:
Are tests included?
...existing
load-config-filetests continue to passBreaking Changes?
List any relevant issue numbers:
Description
We're observing
rolluperrors (link may archive after a few months) in a monorepo that runs parallel builds. Example:Error: ENOENT: no such file or directory, unlink '/home/circleci/project/utils/build/rollup.config-1697053868023.cjs'These errors are becoming more and more common as the performance of the build tooling improves. This PR substitutes the promise signature of Node unlink with the async callback signature. Doing so allows us to safely "eat" the non-critical error of attempting to delete a non-existent temporary config file.