Allow function expression parameters to shadow the function id

[lukastaegert]

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

List any relevant issue numbers:

• resolves RollupError: Identifier has already been declared #5259

Description

In order for the new conflict detection logic to work, function expression ids need to be in a separate scope from the parameters.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
rollup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 21, 2023 6:13am

[github-actions]

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-5259-duplicate-function-id

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-nd0pld54h-rollup-js.vercel.app/repl/?pr=5262

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce6f492) 98.87% compared to head (4ed0707) 98.87%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5262   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files         232      232           
  Lines        8941     8945    +4     
  Branches     2333     2334    +1     
=======================================
+ Hits         8840     8844    +4     
  Misses         42       42           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

This PR has been released as part of rollup@4.5.1. You can test it via npm install rollup.