Allow this.addWatchFile in all hooks

[lukastaegert]

also trigger close hook in watch mode

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

List any relevant issue numbers:

• resolves Calling this.addWatchFile in load hook throws an error if manualChunks is used #5260

Description

This removes any restrictions on this.addWatchFile so that it can now be called in all hooks.

Note that when watch.skipWrite is true, no hooks from the generate phase will be called and closeBundle will not be called.

Last, we now no longer access this in this.addWatchFile.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
rollup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 26, 2023 6:02am

[github-actions]

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-5260-add-watch-file

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-7c9u7n00s-rollup-js.vercel.app/repl/?pr=5270

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (465ae03) 98.86% compared to head (f769150) 98.86%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5270   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files         232      232           
  Lines        8950     8952    +2     
  Branches     2334     2335    +1     
=======================================
+ Hits         8848     8850    +2     
  Misses         43       43           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

This PR has been released as part of rollup@4.6.0. You can test it via npm install rollup.