fix: separately export __proto__ for compatibility with CJS Transpiler Re-exports

[TrickyPi]

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

List any relevant issue numbers:
resolves #5377

Description

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
rollup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 14, 2024 1:52pm

[github-actions]

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/5377

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-8j2blanat-rollup-js.vercel.app/repl/?pr=5380

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7624208) 98.81% compared to head (bd2d4fa) 98.81%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5380   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         232      232           
  Lines        9009     9013    +4     
  Branches     2351     2353    +2     
=======================================
+ Hits         8902     8906    +4     
  Misses         46       46           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TrickyPi]

Currently, the export block is not concise enough when re-exporting '*' from an external module. So, I am wondering whether introducing a flag to control it, such as reExportProtoFromExternal.

[lukastaegert]

Looks good to me, great work!

So, I am wondering whether introducing a flag to control it, such as reExportProtoFromExternal

Yes, I agree. This really is an edge case that of course we should somehow be able to handle, but it adds a lot of overhead to 99% of libraries without any benefit.
output. reExportProtoFromExternal sounds like a good name to me, but of course such a feature would need documentation, which would create some overhead. I think it should be enabled by default for maximum compatibility, but the docs should strongly suggest to disable it as you very likely will not need it.
Do you want to have a go within this PR? Otherwise I think we can also release it as it is and tackle this in a separate PR.

[TrickyPi]

Do you want to have a go within this PR?

OK, I will do it within this PR.

[lukastaegert]

Great work!
The only thing left to do is to add the CLI option to the separate list of CLI options:

In cli/help.md:

  --preserveSymlinks          Do not follow symlinks when resolving files
+ --no-reexportProtoFromExternal Ignore `__proto__` in star re-exports
  --no-sanitizeFileName       Do not replace invalid characters in file names

This text is a suggestion. Here, if the default is "true", we would list the negated option but sort it by its non-negated name. Descriptions should fit within 80 characters.

And this list is duplicated (unchanged!) into docs/command-line-interface/index.md.

[TrickyPi]

Ok, I get it. Thanks for your guidance!

[github-actions]

This PR has been released as part of rollup@4.11.0. You can test it via npm install rollup.