Add ImportAttributesKey to choose keyword ("with" | "assert") #5474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5474 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 238 238
Lines 9450 9451 +1
Branches 2407 2408 +1
=======================================
+ Hits 9338 9339 +1
Misses 47 47
Partials 65 65 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Very nice, this looks really good and complete. There appears to be a small markdown linting issue that should be fixable via npm run lint, then we can merge and release this.
I think this would be a good candidate where we change the default with the next major Rollup version.
lukastaegert
approved these changes
Apr 20, 2024
|
This PR has been released as part of rollup@4.15.0. You can test it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
Description
Add support for "with" import attributes keyword
Import assertions are being deprecated and soon to be removed in chrome
https://v8.dev/features/import-attributes
Chrome, Safari, and nodeJS already support import attributes ("with")
This PR allows to choose the keyword that will be used as is right its not possible since its hardcoded.