Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only optimize annoymous iife #5486

Merged
merged 4 commits into from Apr 23, 2024
Merged

fix: only optimize annoymous iife #5486

merged 4 commits into from Apr 23, 2024

Conversation

liuly0322
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

If a IIFE has a name, it may lose track. In this case we probably should not consider to optimize them.

@vercel Vercel
Copy link

vercel bot commented Apr 23, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 4:10am

@liuly0322 liuly0322 mentioned this pull request Apr 23, 2024
Closed
sparecycles
sparecycles reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@sparecycles sparecycles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I think? (Don't take my word for it, I'm new here!)

src/ast/nodes/shared/FunctionBase.ts Outdated Show resolved Hide resolved
src/ast/nodes/FunctionExpression.ts Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Apr 23, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.83%. Comparing base (18839eb) to head (229b657).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5486   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files         238      238           
  Lines        9560     9563    +3     
  Branches     2444     2446    +2     
=======================================
+ Hits         9449     9452    +3     
  Misses         46       46           
  Partials       65       65

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liuly0322 @sparecycles
fix typo
62c8281 
Co-authored-by: Adam Freidin <adam.freidin@gmail.com>
lukastaegert
lukastaegert approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@lukastaegert lukastaegert added this pull request to the merge queue Apr 23, 2024
Merged via the queue into rollup:master with commit bcf4499 Apr 23, 2024
36 checks passed
@github-actions GitHub Actions
Copy link

This PR has been released as part of rollup@4.16.3. You can test it via npm install rollup.

@liuly0322 liuly0322 deleted the fix-iife branch April 28, 2024 04:19
@lukastaegert lukastaegert mentioned this pull request May 3, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sparecycles sparecycles sparecycles left review comments

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Treeshaking breaks acorn-walk "simple" 4.16.0+
3 participants
@liuly0322 @sparecycles @lukastaegert