Revert function parameter tracking logic for now #5487
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#revert-function-parameter-trackingNotice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly. or load it into the REPL: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5487 +/- ##
==========================================
- Coverage 98.83% 98.81% -0.03%
==========================================
Files 238 238
Lines 9563 9451 -112
Branches 2446 2408 -38
==========================================
- Hits 9452 9339 -113
- Misses 46 47 +1
Partials 65 65 ☔ View full report in Codecov by Sentry. |
|
This PR has been released as part of rollup@4.16.4. You can test it via |
Revert "Revert function parameter tracking logic for now (rollup#5487)" This reverts commit 74da135.
* feat: re-init function parameter tracking Revert "Revert function parameter tracking logic for now (#5487)" This reverts commit 74da135. * refactor: see #5483 comments. squashed with some style commits style: move deoptimizeCache logic style: naming style: naming remove useless comment style: small update * make sure every addUsedPlace has a requestTreeshakingPass This is to make sure if onlyFunctionCallUsed becomes false, there is a new tree-shaking pass to deoptimize it * fix: missing reassigned guard
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Considering some of the unsolved issues we have at the moment, this will revert function parameter tracking for now.