Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rest element should deoptimize parameter values #5503

Merged
merged 1 commit into from Apr 30, 2024

Conversation

liuly0322
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Deoptimize function parameters values when there is a RestElement in function arguments.

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 3:55am

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (dbf0a2e) to head (13fdbff).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5503   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         238      238           
  Lines        9538     9540    +2     
  Branches     2436     2437    +1     
=======================================
+ Hits         9425     9427    +2     
  Misses         48       48           
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, and nice function test!

@lukastaegert lukastaegert added this pull request to the merge queue Apr 30, 2024
@lukastaegert
Copy link
Member

I wonder if this will fix #5483 (comment)

Merged via the queue into rollup:master with commit 89620aa Apr 30, 2024
38 of 39 checks passed
Copy link

This PR has been released as part of rollup@4.17.2. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

function parameter tracking does not handle spread syntax in arguments correctly
2 participants