Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write unit tests #37

Closed
aspiers opened this issue Dec 16, 2023 · 0 comments · Fixed by #99
Closed

write unit tests #37

aspiers opened this issue Dec 16, 2023 · 0 comments · Fixed by #99
Assignees
@aspiers
Labels
tech debt
Milestone
M1.5: pre-launch ...

Comments

@aspiers
Copy link
Member

aspiers commented Dec 16, 2023

Config parsing would be a good place to start.
@aspiers aspiers added this to the 0.2.0 - initial polish milestone Dec 16, 2023
@aspiers aspiers self-assigned this Dec 16, 2023
aspiers added a commit that referenced this issue Jan 15, 2024
@aspiers
refactor: convert parser into two classes and add tests (#37)
a7dcb3e 
Extract the address mapper from the parser, convert both into OO
classes, and add unit tests.

Fixes #37.
@aspiers aspiers mentioned this issue Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aspiers aspiers

Labels
tech debt
Projects
None yet
Milestone
M1.5: pre-launch stretch goals
Development

Successfully merging a pull request may close this issue.

refactor: convert parser into two classes and add tests (#37) rolod0x/rolod0x
1 participant
@aspiers