Prep for v1.2.1 and Chrome Web Store submission #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handler is actually getting called not just when handling clicks from the right-click context menu within a page, but also when clicking the toggle item provided by webext-permission-toggle within the extension context menu. Since it's not suppose to handle anything in that case, make sure it returns gracefully. Also improve debugging in this handler function.
According to research detailed in: fregante/webext-permission-toggle#50 it seems that the `activeTab` permission is only required in Firefox to make webext-permission-toggle work, and in the Chrome family it works fine without it.
Prepare for new release without `activeTab` permission.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
activeTabfrom Chrome manifest, as it seems we don't need it after all.