Fixed Object#with conflict with ActiveSupport 7.1 #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this get merged? |
|
This needs to be reworked on top of release-5.3 branch so that we could release it. |
|
I'll address it today |
flash-gordon
added a commit
that referenced
this pull request
Mar 15, 2024
So that it doesn't clash with the new "feature" from AS, namely, Object#with
flash-gordon
added a commit
that referenced
this pull request
Mar 15, 2024
So that it doesn't clash with the new "feature" from AS, namely, Object#with
|
@rykov I fixed it in rom-core 5.3.1. It seems to work for me, can you please test it out for yourself? |
|
It's fixed on my end. thanks |
|
It's fixed for me too! thank you |
|
thanks folks, I'll close it then |
|
@flash-gordon It works for me as well. Thank you for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveSupport 7.1 defines
Object#withthat interferes with ROM. This PR fixes it.We use
define_method/undef_methodsequence due to uncertain load order. The method needs to be defined forundef_methodto mark a method as undefined. This solution ensures the fix works whether ActiveSupport is loaded before or after ROM.Fixes #684