Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Geo Report can throw an error on saving #17

Closed
roma-glushko opened this issue Oct 14, 2019 · 2 comments
Closed

[Bug] Geo Report can throw an error on saving #17

roma-glushko opened this issue Oct 14, 2019 · 2 comments
Assignees
Labels
component:report:geo type:bug Something isn't working

Comments

@roma-glushko
Copy link
Owner

There can be an issue during Geo report generation.

Preconditions

  • The latest version of Tango
  • Any OS (reproduced on macOS)

Steps to reproduce

  • Run the latest version of Tango like this:
tango geo -l 2019-10-13-transfer.log -r 10-13-geo-report.csv

Expected result

Geo report is generated in any case and saved correctly to the file system.

Actual results

There is an error in the console:

💃 Tango is on the scene!
💃 started to generate a geo report...
💃 reading access logs...
 433.17 MiB / 433.97 MiB [============================================================]  99.81% 1m7s
💃 saving the geo report...
2019/10/14 12:03:05 ipAddress passed to Lookup cannot be nil

No reports are saved.

@roma-glushko roma-glushko added type:bug Something isn't working component:report:geo labels Oct 14, 2019
@roma-glushko roma-glushko self-assigned this Nov 20, 2019
roma-glushko pushed a commit that referenced this issue Nov 20, 2019
…ieve no information mock in a case of errors
@roma-glushko
Copy link
Owner Author

roma-glushko commented Nov 20, 2019

As it turned out, it's possible to get non-IP values in IP list part of log entry. For example:

servername.com
servername.com:80
servername.com:443

Usually, this happens when someone tries to scan a website on vulnerabilities and crafting extraordinary requests.

PR: #24

roma-glushko added a commit that referenced this issue Nov 20, 2019
…p-entries

#17 [Bug] Geo Report can throw an error on saving
@roma-glushko
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:report:geo type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant