Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failure on travis #131

Merged
merged 7 commits into from
Jun 13, 2016
Merged

Fix test failure on travis #131

merged 7 commits into from
Jun 13, 2016

Conversation

satoryu
Copy link
Member

@satoryu satoryu commented May 28, 2016

The current HEAD of the master branch could not pass one test and as for ruby 2.3.1 failed to install gems on which roma depends.

@satoryu
Copy link
Member Author

satoryu commented May 28, 2016

All tests got able to run but not passed yet. https://travis-ci.org/roma/roma/jobs/133544014#L240-L266

@satoryu satoryu mentioned this pull request Jun 4, 2016
Open
@snowmantw
Copy link
Contributor

Hi @satoryu I've found the one CI failure, which is not only in 2.3.1 but also in 2.1 and is about:

localhost_11211 #<NoMethodError: undefined method `write' for nil:NilClass>

looks because of TCPSocket.new in lib/roma/messaging/con_pool.rb sometime fail to create new socket. And the message shows it has been refused by system, suggesting port may has been occupied. I now try to figure out who occupies the port and didn't release it, including the suspicious case from aborted or failed tests who may not clean itself well. I don't know if you're already working on this issue since this PR/issue is for 2.3.1, but if not I'll keep working on that.

@satoryu
Testing roma in all supported ruby versions
deb3fee 
The bug which might happen with ruby 2.1.0 was reported in #131 by
@snowmantw .
So I come to think roma should be tested in all supported ruby versions.
@satoryu
Copy link
Member Author

satoryu commented Jun 5, 2016

As I tried to test for all 2.1 series, the error was reproduced with only ruby 2.1.0. https://travis-ci.org/roma/roma/jobs/135381815#L280-L290

@satoryu
Copy link
Member Author

satoryu commented Jun 7, 2016 •
edited
Loading

@satoryu satoryu merged commit 28d95c1 into master Jun 13, 2016
@satoryu satoryu deleted the fix_test_failure_on_travis branch June 13, 2016 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@satoryu @snowmantw