Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sites to be removed #6

Merged
merged 6 commits into from Apr 5, 2015
Merged

Allow sites to be removed #6

merged 6 commits into from Apr 5, 2015

Conversation

acrogenesis
Copy link
Contributor

Fixes #4
Using the url kaffeine.herokuapp.com/decaf/:name you can remove your app from kaffeine. I also update rails

@romainbutteaud
Copy link
Owner

Awesome! Thank you @acrogenesis! :)
Now we would need some information on the front page to explain the user how to remove the app.

@acrogenesis
Copy link
Contributor Author

@romainbutteaud ready, here is a preview of how it works:
https://www.youtube.com/watch?v=Y1U7npaSqE0

@acrogenesis
Copy link
Contributor Author

bump

@romainbutteaud
Copy link
Owner

Thanks @acrogenesis for your contribution. Since "decaf" will rarely be used I would rather put a link in the footer:
After "Thanks for sharing!", put a link "Decaf" that shows a nice modal with the input and the button to remove the app. What do you think?

@acrogenesis
Copy link
Contributor Author

Seems great to me, I'll update the PR in a moment

@acrogenesis
Copy link
Contributor Author

@romainbutteaud done

@malolans
Copy link

malolans commented Apr 5, 2015

Is there a time line on when this pull request would be merged? I would like to remove my app from kaffeine.

Thanks!

@romainbutteaud
Copy link
Owner

@acrogenesis @malolans merging 👍

romainbutteaud added a commit that referenced this pull request Apr 5, 2015
Allow sites to be removed
@romainbutteaud romainbutteaud merged commit ddf0236 into romainbutteaud:master Apr 5, 2015
@malolans
Copy link

malolans commented Apr 5, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Being able to remove apps from the admin section
3 participants