Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: scroll function, max items to show, input name props #3

Merged
merged 5 commits into from
Apr 27, 2019

Conversation

DeVoresyah
Copy link
Contributor

PR for Issue #2

Usage:

<Dropdown
    name="zipcode"
    :maxItem="10">
</Dropdown>

Options

  • name (optional): An input name | default: dropdown
  • maxItem (optional): Max item to show | default: 10

This was referenced Mar 12, 2019
Copy link
Owner

@romainsimon romainsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think we could let the current default value

src/Dropdown.vue Show resolved Hide resolved
README.md Show resolved Hide resolved
@romainsimon romainsimon added the enhancement New feature or request label Mar 29, 2019
@romainsimon
Copy link
Owner

@DeVoresyah Can you commit my suggested changes ? :)

@DeVoresyah
Copy link
Contributor Author

@DeVoresyah Can you commit my suggested changes ? :)

yes I'll, need a time. Don't have free time for a while

@romainsimon romainsimon merged commit af2170e into romainsimon:master Apr 27, 2019
@romainsimon
Copy link
Owner

I merged your PR and fixed this here #7

@DeVoresyah
Copy link
Contributor Author

I merged your PR and fixed this here #7

thanks and sorry, I have not had time to change it

@romainsimon
Copy link
Owner

No problem ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants