Update migration command to enable/disable transactions #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mmabrouk , |
removed logging format added test Added --no-use-transaction option for migration
mmabrouk
changed the title
|
@roman-right I added a simple test. The perfect way to do it would be to add a separate mongodb service (through an action) without replica. But honestly, that would be an overkill. |
|
@roman-right Do you have feedback on this? |
|
Hi @mmabrouk , |
|
Hi @mmabrouk , Thank you for your work! Merged. It will be published in the next 2 days |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modified version of Beanie that includes an option to enable or disable transactions during migrations. Please see the motivation here (#827). To run a migration without a transaction, use the following command:
Please let me know if you'd like this feature in the upstream, and whether you require any changes to the PR. I will ensure to squash the commits and tidy things up.