Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max targets? #2

Closed
lbrictson opened this issue Aug 21, 2017 · 3 comments
Closed

Max targets? #2

lbrictson opened this issue Aug 21, 2017 · 3 comments

Comments

@lbrictson
Copy link

Is there a max amount of addresses this can ping? I tried using the multi_ping method and giving it 10 retries with 10 seconds for a list of 488 targets, but i'm always getting between 210 and 220 without any response data.

Any ideas? Love this tool otherwise!

@jbrendel
Copy link
Contributor

Sorry for the delayed response. I'm glad you like multiping.

To be honest, I haven't had a chance to test it with such large numbers of addresses. It "should" work. Are those 488 targets on your local network, or out there on the Internet? It is possible that you are running into some rate limiting issues in your network or service provider. ICMP packets in such large quantities may be considered suspicious.

@mpghf
Copy link
Contributor

mpghf commented Jan 8, 2018

This issue is caused by the limited receive buffer size. The receive buffer on the socket varies according to the platform.

For local targets, the replies come back faster than they can be read from the socket, the socket buffer overflows, and the replies are lost.

I'll submit a patch shortly to use a larger receive buffer, but perhaps in the long run the receive buffer should be set according to the number of pinged targets.

@jbrendel
Copy link
Contributor

jbrendel commented Jan 8, 2018

Fixed by PR #5. Thank you mpghf for the contribution!

@jbrendel jbrendel closed this as completed Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants