This patch addresses two issues: #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small socket receive buffer can result in a buffer overflow (and lost ping replies) if many fast targets are pinged. The receive buffer has accordingly been enlarged to 131072 bytes. In the long run this should probably be varied according to the number of pinged targets. The second issue is that the errno values are currently hard-coded. On platforms other than Windows and Linux this causes trouble. Rather use the values defined in the errno package: errno.EWOULDBLOCK, which resolves to 11 on Linux, 10035 on Windows, 35 on FreeBSD, and other values on other platforms.
|
Thank you for your contribution, very nice. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small socket receive buffer can result in a buffer overflow (and lost ping replies) if many fast targets are pinged. The receive buffer has accordingly been enlarged to 131072 bytes. In the long run this should probably be varied according to the number of pinged targets.
The second issue is that the errno values are currently hard-coded. On platforms other than Windows and Linux this causes trouble. Rather use the values defined in the errno package: errno.EWOULDBLOCK, which resolves to 11 on Linux, 10035 on Windows, 35 on FreeBSD, and other values on other platforms.