Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about flaky comparison results #191

Closed
jradom opened this issue Aug 24, 2020 · 11 comments
Closed

Questions about flaky comparison results #191

jradom opened this issue Aug 24, 2020 · 11 comments
Labels
question Further information is requested

Comments

@jradom
Copy link

jradom commented Aug 24, 2020

Hello,

I use your tool and it had worked great for me until now. Here Is my scenario.
I have an app that is going through an upgrade.

  1. I make screenshots using Selenium for several pages and store them as baseline images (before the upgrade).
  2. I run my app after the upgrade and make screenshots of the same pages
  3. I compare on the fly each new and old/baseline pages and use .setAllowingPercentOfDifferentPixels(10)
  4. Sometimes my result is MATCH or MISMATCH or SIZE_MISMATCH and its' random

What can you suggest to make it work stable?
Oh, differences in fact are minimal. I use the Chrome browser to run my app

Your help will be greatly appreciated

Thanks a lot in advance

Jeff

@romankh3
Copy link
Owner

Hi @jradom,
Firstly, setAllowingPercentOfDifferentPixels(10) is a really powerful configuration, which was added for you (as I remember).

I'd suggest starting comparing without this config, it's for different MISMATCH and MATCH

If we speak about SIZE_MISMATCH - it's harder. Before say something I need to reproduce it. From my perspective, if you have this result, it means, that the screenshots are not the same.

Hope, it was helpful for yiu.

@jradom
Copy link
Author

jradom commented Sep 1, 2020 via email

@romankh3
Copy link
Owner

romankh3 commented Sep 1, 2020

SIZE_MISMATCH means, that the image sizes are different. For example:
image1 has 100x1000 pixels
image2 has 101x1000 pixels
In this case, would be SIZE_MISMATCH

Best regards,
Roman

@romankh3 romankh3 added the question Further information is requested label Sep 1, 2020
@jradom
Copy link
Author

jradom commented Sep 1, 2020 via email

@romankh3
Copy link
Owner

romankh3 commented Sep 1, 2020

I don't know for sure how selenium works, that's why I can't help with it.
Also, I'm not familiar with automation testing tools and approaches. I'm a developer, not qa engineer..
I wish I can help you...

@jradom
Copy link
Author

jradom commented Sep 1, 2020 via email

@romankh3 romankh3 closed this as completed Sep 8, 2020
@jradom
Copy link
Author

jradom commented Sep 9, 2020 via email

@jradom
Copy link
Author

jradom commented Nov 10, 2020

Roman,

I've just downloaded your Jar file but how can I run it, put parameters and output. Like I said I plan to call CLI from Typrescript

Please, let me know

Thanks a lot in advance

Jeff

@romankh3
Copy link
Owner

Jeff,
This jar of image-comparison doesn't have main method to run as a jar.
For this purpose must be created the separated project with the main method with image-comparison as a dependency.

@jradom
Copy link
Author

jradom commented Nov 11, 2020 via email

@jradom
Copy link
Author

jradom commented Nov 13, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants