Add test for check message

romanmatyus · Apr 24, 2016 · a1938ab · a1938ab
1 parent 6a92bb0
commit a1938ab
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/src/RM/SMSender/EuroSms/Sender.php b/src/RM/SMSender/EuroSms/Sender.php
@@ -112,10 +112,10 @@ private function checkConfig($id, $key)
 	 */
 	private function check(IMessage $message)
 	{
-		if (empty($message->getTo()))
-			throw new MissingParameterException('Message has empty recipent number. Use method setTo().');
 		if (empty($message->getFrom()))
 			throw new MissingParameterException('Message has empty sender. Use method setFrom().');
+		if (empty($message->getTo()))
+			throw new MissingParameterException('Message has empty recipent number. Use method setTo().');
 		if (empty($message->getText()))
 			throw new MissingParameterException('Message has empty text. Use method setText().');
 		return TRUE;

diff --git a/tests/RM/SMSender/EuroSms/Sender.send().phpt b/tests/RM/SMSender/EuroSms/Sender.send().phpt
@@ -10,9 +10,6 @@ use Tester\Assert;
 require __DIR__ . '/../../../bootstrap.php';
 
 $message = new RM\SMSender\EuroSms\Message;
-$message->setFrom('Tester')
-	->setTo('+421900123456')
-	->setText('Text');
 
 $config = Neon::decode(file_get_contents(__DIR__ . '/../../../secret.neon'));
 
@@ -23,6 +20,24 @@ $sender->config([
 	'key' => '12345678',
 ]);
 
+Assert::exception(function() use ($sender, $message) {
+	$sender->send($message);
+}, 'RM\SMSender\MissingParameterException', 'Message has empty sender. Use method setFrom().');
+
+$message->setFrom('Tester');
+
+Assert::exception(function() use ($sender, $message) {
+	$sender->send($message);
+}, 'RM\SMSender\MissingParameterException', 'Message has empty recipent number. Use method setTo().');
+
+$message->setTo('+421900123456');
+
+Assert::exception(function() use ($sender, $message) {
+	$sender->send($message);
+}, 'RM\SMSender\MissingParameterException', 'Message has empty text. Use method setText().');
+
+$message->setText('Text');
+
 Assert::exception(function() use ($sender, $message) {
 	$sender->send($message);
 }, 'RM\SMSender\GatewayException', 'BadSignature');