Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VGMdb] Album image previews are broken #5

Closed
TheShadowRunner opened this issue Jan 15, 2021 · 10 comments
Closed

[VGMdb] Album image previews are broken #5

TheShadowRunner opened this issue Jan 15, 2021 · 10 comments
Labels
question Further information is requested

Comments

@TheShadowRunner
Copy link

As VGMdbAlbumParser.inc expects .jpg or .png images but VGMdb recently switched to .webp.
Hoping a fix is possible.
Thanks for your dedication in keeping these scripts going !

@romanoh
Copy link
Owner

romanoh commented Jan 15, 2021

Hello

the VGMdb is working for me, the Json and normal version, can you give an album example?
also the file extension does not matter as the parser gets the full link.

imagem

@romanoh romanoh added the question Further information is requested label Jan 15, 2021
@TheShadowRunner
Copy link
Author

TheShadowRunner commented Jan 15, 2021

Here's an exemple :
https://vgmdb.net/album/107313

More info directly from the horse's mouth:
"album cover filetype is determined by whatever type the original image was", meaning if the format uploaded was jpg, it'll remain jpg [and work with the script].
But if a user uploads a webp, vgmdb will use it as-is (= my exemple), in this case it breaks the script.
So they didn't switch to webp completely but rather added support for it, I was mistaken.

Thanks for your support.

@romanoh
Copy link
Owner

romanoh commented Jan 15, 2021

You are right. i first must see if mp3tag suports webp.
edit:
it does not only :
imagem

i see what can i do

Edit:
The ID3 standard recommends png and jpg for best compatibility.

@romanoh
Copy link
Owner

romanoh commented Jan 15, 2021

I cannot do it by changing the .webp to .jpg, in the script, it gives an error.
So or mp3tag change support(made a post in forum) or you have to make it by hand: download the file and change the extension.

@romanoh romanoh closed this as completed Jan 17, 2021
@romanoh
Copy link
Owner

romanoh commented Apr 6, 2021

@TheShadowRunner
Copy link
Author

Yes I saw Florian added support. But without auto-convertion to PNG or JPG it doesn't make much sense ?

@romanoh
Copy link
Owner

romanoh commented Apr 7, 2021

i did some test in the link you give and it woks.
the auto conversion i think is another thing.

@TheShadowRunner
Copy link
Author

TheShadowRunner commented Apr 7, 2021

Thanks for your feedback, apparently mp3tag is able to convert webp to jpg/png after all ? (how?) but it won't do it automatically.
Or is the conversion something that is done at your level on the Source script ?

@romanoh
Copy link
Owner

romanoh commented Apr 7, 2021

I think there is no conversion, if you use the mp3tag software it gets the .webp file, and it saves it to the audio tags.
and if you save it next to the audio file it stays .webp. It is one more file image suportedd:
imagem

@TheShadowRunner
Copy link
Author

Understood. The goal was being able to see webp image previews so this "issue" is fixed, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants