Changing handler to work with singletons

[cvallance]

Given that the recommended lifetime of an ElasticClient is for it to be a singleton, I've changed / updated the handler to work with this.

Note: Sorry, I'm on linux and the whole project wouldn't build so I just took a stab at what sould be removed / addded etc.

[romansp]

Hi @cvallance, thanks for bringing my attention to this and I'm more than willing to merge if it addresses the issue you're experiencing. Unfortunately I haven't used neither MiniProfiler nor ElasticClient in a long time. I will try to look into it this week and hopefully release a fixed nuget package.

Regarding solution compilation I believe it's legacy ASP.NET MVC sample that won't build? Will do something about it too.

[cvallance]

Thanks @romansp . That would be great if you can fix it but no rush... I've just taken your code and put it into my client creation as is. So I can tell you that this works:

settings.OnRequestCompleted(details =>
{
    var profiler = MiniProfiler.Current;
    if (profiler?.Head == null || details?.DebugInformation == null)
    {
        return;
    }

    var duration = details.AuditTrail?.Sum(c => (c.Ended - c.Started).TotalMilliseconds) ?? 0;
    profiler.Head.AddCustomTiming("elasticsearch",
        new CustomTiming(profiler, details.DebugInformation)
        {
            Id = Guid.NewGuid(),
            DurationMilliseconds = Convert.ToDecimal(duration),
            ExecuteType = details.HttpMethod.ToString(),
        });
});

_client = new ElasticClient(settings);

[romansp]

Oh, okay great!

Does it mean that previous implementation could be possibly causing a memory-leak by pinning reference to MiniProfiler instance inside _profiler field?

[cvallance]

Totally depends on the lifecycle management of the ElasticClient instance I guess. I think it would've only been a leak if they had a singleton instance and even then it's only 1 instance... plus it wouldn't have worked as I found out.

End of the day, no big deal 😄

[romansp]

Hey @cvallance! Sorry for the delay, 6.1.1 package is up on the nuget feed. Please let me know of any issues. And thanks again for your fix.