Update min versions for installation #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the minimum version for Rust from 1.28 to the current latest which is 1.33. This is because 1.28 may fail on build due to It also updates the minimum version of Electrum to the current latest of 3.3 since version 3.2 is officially unsupported due to a known phishing vulnerability.
sangaman
force-pushed
the
min-rust-version
branch
from
a22357e
to
cad3551
Compare
romanz
approved these changes
Apr 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the minimum version for Rust from 1.28 to the current latest which is 1.33. This is because 1.28 may fail on build due to #129.
It also updates the minimum version of Electrum to the current latest of 3.3 since version 3.2 is officially unsupported due to a known phishing vulnerability.