You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ATM I am adding calendars for Slovak dioceses, however, I don’t we ever defined the filename and class naming rules.
Based on the current filenames and class names, I suggest to used the following rules:
particular calendar filenames:
use ${continent}.${subcontinent}.${region}.${country}.${dioceseCity}.${parishCity}.${parishName}.${churchName}.ts format for filenames of particular calendars, where:
continent: is the continent name:
america for North/Central/South Americas;
africa;
eurasia for Asia and Europe;
australia for Australia and Oceania;
antarctica for Antartica;
subcontinent: is the subcontinent name;
north-america;
central-america;
south-america;
europe;
asia;
region: for regional calendars (like Austria-Germany-Switzerland);
country: is the country name;
dioceseCity: is the diocese seat (city) name;
parishCity: parish city/town/vilage name;
parishName: parish name (patronage) when there are multiple parishes in a city/town/vilage;
churchName: a church name when a particular celebration is celebrated in a parcticular church only;
each part (one of the six format items of a filename) should be in kebab-case;
particular calendar class names:
same format but with underscores instead of dots and without .ts extension should be used for class names in particular calendars (i.e. ${continent}_${subcontinent}_${region}_${country}_${dioceseCity}_${parishCity}_${parishName}_${churchName});
each part (one of the six format items of a filename) should be in PascalCase/UpperCamelCase;
additional rules and notes:
we should omit any level as needed, based on the calendar inheritance of the particular calendar;
I decided to combine Americas, and Asia and Europe to America and Eurasia for simplicity purposes, because:
[America] some celebrations are celebrated thoughout Americas, others only in North/Central/South Americas (AFAIK);
[Eurasia] there are separate patrons of European and Asian part of Russia, thus Russia should be part of both Europe and Asia (in national calendar; thus eurasia.russia.ts), however on regional level (diocese, parish) it should be part of either Asia or Europe only (thus eurasia.europe.russia.ts or eurasia.asia.russia.ts):
this is not ideal; @emagnier, you might come up with a better solution;
if we won’t find a better solution, then (either):
we should add a way to to exclude a calendar from inheritance;
simply inherit from calendars based on the calendar name (either filename of class name) or explicitly define from which calendar should a calendar should inherit;
[country: diocese: parish: church in parish] slovakia.bratislava.martin-of-tours.cathedral.ts → eurasia.europe.slovakia.bratislava.martin-of-tours.cathedral-of-saint-martin-of-tours.ts (Eurasia_Europe_Slovakia_Bratislava_MartinOfTours_CathedralOfMartinOfTours);
[country] scotland.ts → eurasia.europe.united-kingdom.scotland.ts or (when there is no united-kingdom regional calendar) eurasia.europe.scotland.ts (Eurasia_Europe_UnitedKingdom_Scotland or Eurasia_Europe_Scotland);
[country] wales.ts → eurasia.europe.united-kingdom.wales.ts or (when there is no united-kingdom regional calendar) eurasia.europe.wales.ts (Eurasia_Europe_UnitedKingdom_Wales or Eurasia_Europe_Wales);
[country] england.ts → eurasia.europe.united-kingdom.england.ts or (when there is no united-kingdom regional calendar) eurasia.europe.england.ts (Eurasia_Europe_UnitedKingdom_England or Eurasia_Europe_England);
[country] ireland.ts → eurasia.europe.united-kingdom.ireland.ts or (when there is no united-kingdom regional calendar) eurasia.europe.ireland.ts (Eurasia_Europe_UnitedKingdom_UnitedKingdom or Eurasia_Europe_UnitedKingdom);
Another thing we might consider is to move the particular calendars into subfolders, e.g. diocesan calendars would go to lib/particular-calendars/diocese. Thus the particular calendars would be easier to distinguish from other particular calendars.
Take for example the calendars for the Archdiocese of Košice, Slovakia and the City of Košice, Slovakia:
The more I am into adding the calendars for Slovak dioceses to romcal, the more I think that explicit specification of calendars from which a calendar inherits is better way to deal with this. This, however, duplicates the list of calendars from which a calendar inherits and is thus non-KISS. 🤔
ATM I am adding calendars for Slovak dioceses, however, I don’t we ever defined the filename and class naming rules.
Based on the current filenames and class names, I suggest to used the following rules:
${continent}.${subcontinent}.${region}.${country}.${dioceseCity}.${parishCity}.${parishName}.${churchName}.ts
format for filenames of particular calendars, where:continent
: is the continent name:america
for North/Central/South Americas;africa
;eurasia
for Asia and Europe;australia
for Australia and Oceania;antarctica
for Antartica;subcontinent
: is the subcontinent name;north-america
;central-america
;south-america
;europe
;asia
;region
: for regional calendars (like Austria-Germany-Switzerland);country
: is the country name;dioceseCity
: is the diocese seat (city) name;parishCity
: parish city/town/vilage name;parishName
: parish name (patronage) when there are multiple parishes in a city/town/vilage;churchName
: a church name when a particular celebration is celebrated in a parcticular church only;.ts
extension should be used for class names in particular calendars (i.e.${continent}_${subcontinent}_${region}_${country}_${dioceseCity}_${parishCity}_${parishName}_${churchName}
);eurasia.russia.ts
), however on regional level (diocese, parish) it should be part of either Asia or Europe only (thuseurasia.europe.russia.ts
oreurasia.asia.russia.ts
):Examples
americas.ts
→america.ts
(class name:America
);europe.ts
→eurasia.europe.ts
(Eurasia_Europe);argentina.ts
→america.south-america.argentina.ts
oramerica.argentina.ts
(America_SouthAmerica_Argentina
orAmerica_Argentina
);australia.ts
→australia.australia.ts
(Australia_Australia
);russia.ts
→eurasia.russia.ts
(Eurasia_Russia
);eurasia.europe.russia.moscow.ts
(Eurasia_Europe_Russia
);slovakia.ts
→eurasia.europe.slovakia.ts
(Eurasia_Europe_Slovakia
);slovakia.bratislava.ts
→eurasia.europe.slovakia.bratislava.ts
(Eurasia_Europe_Slovakia_Bratislava
);slovakia.banska-bystrica.ts
→eurasia.europe.slovakia.banska-bystrica.ts
(Eurasia_Europe_Slovakia_BanskaBystrica
);slovakia.banska-bystrica.cathedral.ts
→eurasia.europe.slovakia.banska-bystrica.cathedral.ts
(Eurasia_Europe_Slovakia_BanskaBystrica_Cathedral
);slovakia.bratislava.martin-of-tours.cathedral.ts
→eurasia.europe.slovakia.bratislava.martin-of-tours.cathedral-of-saint-martin-of-tours.ts
(Eurasia_Europe_Slovakia_Bratislava_MartinOfTours_CathedralOfMartinOfTours
);france.ts
→eurasia.europe.france.ts
(Eurasia_Europe_France
);france.paris.ts
→eurasia.europe.france.paris.ts
(Eurasia_Europe_France_Paris
);france.strasbourg.ts
→eurasia.europe.france.strasbourg.ts
(Eurasia_Europe_France_Strasbourg
);france.saint-denis.ts
→eurasia.europe.france.saint-denis.ts
(Eurasia_Europe_France_SaintDenis
);scotland.ts
→eurasia.europe.united-kingdom.scotland.ts
or (when there is nounited-kingdom
regional calendar)eurasia.europe.scotland.ts
(Eurasia_Europe_UnitedKingdom_Scotland
orEurasia_Europe_Scotland
);wales.ts
→eurasia.europe.united-kingdom.wales.ts
or (when there is nounited-kingdom
regional calendar)eurasia.europe.wales.ts
(Eurasia_Europe_UnitedKingdom_Wales
orEurasia_Europe_Wales
);england.ts
→eurasia.europe.united-kingdom.england.ts
or (when there is nounited-kingdom
regional calendar)eurasia.europe.england.ts
(Eurasia_Europe_UnitedKingdom_England
orEurasia_Europe_England
);ireland.ts
→eurasia.europe.united-kingdom.ireland.ts
or (when there is nounited-kingdom
regional calendar)eurasia.europe.ireland.ts
(Eurasia_Europe_UnitedKingdom_UnitedKingdom
orEurasia_Europe_UnitedKingdom
);austria.ts
→eurasia.europe.austria-germany-switzerland.austria.ts
(Eurasia_Europe_AustriaGermanySwitzerland_Austria
).The text was updated successfully, but these errors were encountered: