chore: update prettier v3 (#4740)

* chore: update prettier

* update snapshot

* fix build error

* update pnpm to v8

.github/workflows/pull_request_js.yml

@@ -47,7 +47,7 @@ jobs:
             ${{ runner.os }}-
       - uses: pnpm/action-setup@v2.2.4
         with:
-          version: 7
+          version: 8
       - name: Install toolchain
         uses: moonrepo/setup-rust@v0
       - name: Build WASM module for the web

crates/rome_formatter_test/src/prettier/package.json

@@ -4,12 +4,9 @@
 		"start": "node prepare_tests"
 	},
 	"dependencies": {
-		"prettier": "2.8.8"
-	},
-	"devDependencies": {
-		"@types/prettier": "^2.7.1"
+		"prettier": "3.0.0"
 	},
 	"engines": {
-		"pnpm": "^7.0.0"
+		"pnpm": "^8.0.0"
 	}
 }

crates/rome_formatter_test/src/prettier/prepare_tests.js

@@ -86,7 +86,7 @@ async function traverseDir(dir, input_config) {
 				try {
 					// We need to reformat prettier snapshot
 					// because Rome and Prettier have different default options
-					snapshotContent = prettier.format(snapshotContent, config);
+					snapshotContent = await prettier.format(snapshotContent, config);
 				} catch (error) {
 					console.error(`Prettier format error in ${filePath}: ${error}`);
 				}
@@ -99,7 +99,7 @@ async function traverseDir(dir, input_config) {
 
 				try {
 					// Try to format input with prettier
-					const prettierOutput = prettier.format(content, config);
+					const prettierOutput = await prettier.format(content, config);
 
 					const outDir = path.resolve(outPath, '..');
 					await fs.mkdir(outDir, { recursive: true });

crates/rome_js_formatter/tests/specs/prettier/js/arrays/preserve_empty_lines.js

@@ -10,3 +10,84 @@ a = [
 
 
 ]
+
+b = [
+  100,
+
+  (200)
+  ,
+
+  300
+  ,
+
+  1
+  ,
+  2, 3
+]
+
+c = [
+  "apple",
+  "banana",
+  "blueberry",
+
+  "red",
+  "blue"
+  ,
+  "yellow",
+
+  "broccoli",
+  "celery",
+  "lettuce"
+  ,
+
+  "green"
+  ,
+  "green",
+  "green",
+
+  //an egg
+  "egg",
+  //a bigger egg
+  "big egg"
+  //the biggest egg
+  ,
+  "huge egg"
+  ,
+
+  //not an egg
+  "lasagna"
+
+]
+
+_ = [
+  a,
+
+  b //
+]
+
+_ = [
+  (a),
+
+  b, //
+];
+
+_ = [
+  (((((
+    a = b/* comment */))/* comment */))),
+
+  c //
+]
+
+_ = [
+  (((((
+    (a = b)/* comment */))/* comment */))),
+
+  c //
+]
+
+_ = [
+  (a=b
+
+  ),
+  b, //
+];

crates/rome_js_formatter/tests/specs/prettier/js/arrays/preserve_empty_lines.js.prettier-snap

@@ -5,3 +5,70 @@ a = [
 
   4,
 ];
+
+b = [
+  100,
+
+  200,
+
+  300,
+
+  1, 2, 3,
+];
+
+c = [
+  "apple",
+  "banana",
+  "blueberry",
+
+  "red",
+  "blue",
+  "yellow",
+
+  "broccoli",
+  "celery",
+  "lettuce",
+
+  "green",
+  "green",
+  "green",
+
+  //an egg
+  "egg",
+  //a bigger egg
+  "big egg",
+  //the biggest egg
+  "huge egg",
+
+  //not an egg
+  "lasagna",
+];
+
+_ = [
+  a,
+
+  b, //
+];
+
+_ = [
+  a,
+
+  b, //
+];
+
+_ = [
+  (a = b) /* comment */ /* comment */,
+
+  c, //
+];
+
+_ = [
+  (a = b) /* comment */ /* comment */,
+
+  c, //
+];
+
+_ = [
+  (a = b),
+  b, //
+];

crates/rome_js_formatter/tests/specs/prettier/js/arrays/tuple-and-record.js

@@ -0,0 +1,19 @@
+a = [
+  [1,2],
+  [1,2],
+]
+
+a = [
+  #[1,2],
+  #[1,2],
+]
+
+a = [
+  {a, b},
+  {a, b},
+]
+
+a = [
+  #{a, b},
+  #{a, b},
+]

crates/rome_js_formatter/tests/specs/prettier/js/arrays/tuple-and-record.js.prettier-snap

@@ -0,0 +1,19 @@
+a = [
+  [1, 2],
+  [1, 2],
+];
+
+a = [
+  #[1, 2],
+  #[1, 2],
+];
+
+a = [
+  { a, b },
+  { a, b },
+];
+
+a = [
+  #{ a, b },
+  #{ a, b },
+];