PR feedback

crates/rome_js_analyze/src/analyzers/nursery/use_import_restrictions.rs

@@ -119,7 +119,7 @@ fn get_restricted_import(module_path: &SyntaxTokenText) -> Option<ImportRestrict
         return None;
     }
 
-    let mut path_parts: Vec<&str> = module_path.text().split('/').collect();
+    let mut path_parts: Vec<_> = module_path.text().split('/').collect();
     let mut index_filename = None;
 
     if let Some(extension) = get_extension(&path_parts) {

crates/rome_js_analyze/tests/specs/nursery/useImportRestrictions/validPackagePrivateImports.js

@@ -3,9 +3,6 @@
 // Imports within the same module are always allowed.
 import { fooPackageVariable } from "./foo.js";
 
-// Imports within the same module are always allowed.
-import { fooPackageVariable } from "./foo.js";
-
 // Resources (anything other than JS/TS files) are exempt.
 import { barResource } from "../aunt/bar.png";
 
@@ -17,3 +14,9 @@ import { subPackageVariable } from "./sub/index.js";
 
 // Library imports are exempt.
 import useAsync from "react-use/lib/useAsync";
+
+// Including library imports with an extension.
+import map from "lodash/map.js";
+
+// Scoped packages work too.
+import netlify from "@astrojs/netlify/functions.js";

crates/rome_js_analyze/tests/specs/nursery/useImportRestrictions/validPackagePrivateImports.js.snap

@@ -9,9 +9,6 @@ expression: validPackagePrivateImports.js
 // Imports within the same module are always allowed.
 import { fooPackageVariable } from "./foo.js";
 
-// Imports within the same module are always allowed.
-import { fooPackageVariable } from "./foo.js";
-
 // Resources (anything other than JS/TS files) are exempt.
 import { barResource } from "../aunt/bar.png";
 
@@ -24,6 +21,12 @@ import { subPackageVariable } from "./sub/index.js";
 // Library imports are exempt.
 import useAsync from "react-use/lib/useAsync";
 
+// Including library imports with an extension.
+import map from "lodash/map.js";
+
+// Scoped packages work too.
+import netlify from "@astrojs/netlify/functions.js";
+
 ```