Merge branch 'main' into fix-false-positive-useHookAtTopLevel

rome · May 31, 2023 · fc432c6 · fc432c6
2 parents 684aa36 + 55e1613
commit fc432c6
Show file tree

Hide file tree

Showing 128 changed files with 2,856 additions and 4,576 deletions.
diff --git a/.github/workflows/bench_analyzer.yml b/.github/workflows/bench_analyzer.yml
@@ -62,11 +62,9 @@ jobs:
           critcmp main pr >> output
           echo "\`\`\`" >> output
           cat output
-          comment="$(cat output)"
-          comment="${comment//'%'/'%25'}"
-          comment="${comment//$'\n'/'%0A'}"
-          comment="${comment//$'\r'/'%0D'}"
-          echo "comment=$comment" >> $GITHUB_OUTPUT
+          echo "comment<<EOF" >> $GITHUB_OUTPUT
+          cat output >> $GITHUB_OUTPUT
+          echo "EOF" >> $GITHUB_OUTPUT
 
       - name: Write a new comment
         uses: peter-evans/create-or-update-comment@v1.4.5

diff --git a/.github/workflows/bench_formatter.yml b/.github/workflows/bench_formatter.yml
@@ -62,11 +62,9 @@ jobs:
           critcmp main pr >> output
           echo "\`\`\`" >> output
           cat output
-          comment="$(cat output)"
-          comment="${comment//'%'/'%25'}"
-          comment="${comment//$'\n'/'%0A'}"
-          comment="${comment//$'\r'/'%0D'}"
-          echo "comment=$comment" >> $GITHUB_OUTPUT
+          echo "comment<<EOF" >> $GITHUB_OUTPUT
+          cat output >> $GITHUB_OUTPUT
+          echo "EOF" >> $GITHUB_OUTPUT
 
       - name: Write a new comment
         uses: peter-evans/create-or-update-comment@v1.4.5

diff --git a/.github/workflows/bench_parser.yml b/.github/workflows/bench_parser.yml
@@ -61,11 +61,9 @@ jobs:
           critcmp main pr >> output
           echo "\`\`\`" >> output
           cat output
-          comment="$(cat output)"
-          comment="${comment//'%'/'%25'}"
-          comment="${comment//$'\n'/'%0A'}"
-          comment="${comment//$'\r'/'%0D'}"
-          echo "comment=$comment" >> $GITHUB_OUTPUT
+          echo "comment<<EOF" >> $GITHUB_OUTPUT
+          cat output >> $GITHUB_OUTPUT
+          echo "EOF" >> $GITHUB_OUTPUT
 
       - name: Write a new comment
         uses: peter-evans/create-or-update-comment@v1.4.5

diff --git a/.github/workflows/parser_conformance.yml b/.github/workflows/parser_conformance.yml
@@ -68,11 +68,10 @@ jobs:
           echo "## Parser conformance results on ${{ matrix.os }}" > output
           cargo coverage compare ./base_results.json ./new_results.json --markdown >> output
           cat output
-          comment="$(cat output)"
-          comment="${comment//'%'/'%25'}"
-          comment="${comment//$'\n'/'%0A'}"
-          comment="${comment//$'\r'/'%0D'}"
-          echo "comment=$comment" >> $GITHUB_OUTPUT
+          echo "comment<<EOF" >> $GITHUB_OUTPUT
+          cat output >> $GITHUB_OUTPUT
+          echo "EOF" >> $GITHUB_OUTPUT
+
 
       - name: Get the PR number
         if: github.event_name == 'pull_request'

diff --git a/.github/workflows/release_cli.yml b/.github/workflows/release_cli.yml
@@ -164,30 +164,12 @@ jobs:
             ./npm/wasm-web
           if-no-files-found: error
 
-  upload-schema:
-    name: Upload configuration JSON schema
-    runs-on: ubuntu-latest
-    needs: check
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v3
-        with:
-          fetch-depth: 1
-      # Upload the JSON schema of the configuration
-      - name: Upload configuration JSON schema
-        uses: actions/upload-artifact@v3
-        with:
-          name: json-schema
-          path: ./npm/rome/configuration_schema.json
-          if-no-files-found: error
-
   publish:
     name: Publish
     runs-on: ubuntu-latest
     needs:
       - build
       - build-wasm
-      - upload-schema
     environment: npm-publish
     steps:
       - uses: actions/checkout@v3
@@ -196,10 +178,6 @@ jobs:
         uses: actions/download-artifact@v3
         with:
           name: cli
-      - name: Download configuration JSON schema
-        uses: actions/download-artifact@v3
-        with:
-          name: json-schema
       - name: Download WASM artifacts
         uses: actions/download-artifact@v3
         with:
@@ -240,6 +218,5 @@ jobs:
           prerelease: ${{ needs.build.outputs.prerelease == 'true' }}
           files: |
             rome-*
-            configuration_schema.json
           fail_on_unmatched_files: true
           generate_release_notes: true
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,17 @@
 
 ## [Unreleased]
 
+### CLI
+### Configuration
+### Editors
+### Formatter
+### Linter
+### Parser
+### VSCode
+### JavaScript APIs
+
+## 12.1.3
+
 ### CLI
 
 #### Other changes
@@ -16,17 +27,22 @@
 - Fix an issue where all the `nursery` were enabled when the `"nursery": {}` object
 was defined [#4479](https://github.com/rome/tools/issues/4479)
 
-### Editors
 ### Formatter
+
 ### Linter
 
 #### Other changes
 
 - Fix false positive diagnostics ([#4483](https://github.com/rome/tools/issues/4483)) that [`useHookAtTopLevel`](https://docs.rome.tools/lint/rules/usehookattoplevel/) caused to returning call expressions of a hook.
+- Revert [#4359](https://github.com/rome/tools/issues/4359)
+
 
 ### Parser
-### VSCode
-### JavaScript APIs
+
+#### Other changes
+
+- Revert [#4359](https://github.com/rome/tools/issues/4359)
+
 
 ## 12.1.2