Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Update js-parser tests to match babel-parser #11

Closed
sebmck opened this issue Feb 20, 2020 · 3 comments
Closed

Update js-parser tests to match babel-parser #11

sebmck opened this issue Feb 20, 2020 · 3 comments

Comments

@sebmck
Copy link
Contributor

sebmck commented Feb 20, 2020

js-parser is a fork of babel-parser. The code has diverged way too far to allow any sort of commit merging but the test fixtures are still valuable. packages/@romejs/js-parser/__rtests__/__rfixtures__/ should be updated with those from babel-parser/test/fixtures and the numerous bugs fixed that they uncover.

@sebmck sebmck added the code label Feb 20, 2020
@sebmck sebmck mentioned this issue Feb 20, 2020
@pajaydev
Copy link

@sebmck Do I need to include the missing test fixtures from babel-parse ?.

@sebmck
Copy link
Contributor Author

sebmck commented Feb 29, 2020

@pajaydev Yep. The options.json files will also need to be updated since they use options that Rome doesn't. Also removing any tests for syntax that Rome won't support such as some of the TC39 proposals.

@pajaydev
Copy link

pajaydev commented Mar 1, 2020

@sebmck okay cool. Thanks 👍

sebmck pushed a commit that referenced this issue Apr 24, 2020
@sebmck sebmck closed this as completed in 76c7702 Jul 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants