Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

📎 Tiling Views #2620

Closed
Tracked by #2616
NicholasLYang opened this issue May 26, 2022 · 13 comments · Fixed by #3559
Closed
Tracked by #2616

📎 Tiling Views #2620

NicholasLYang opened this issue May 26, 2022 · 13 comments · Fixed by #3559
Assignees
Labels
A-Tooling Area: our own build, development, and release tooling good first issue Good for newcomers S-Planned Status: planned by the team, but not in the short term task A task, an action that needs to be performed

Comments

@NicholasLYang
Copy link
Contributor

Description

There are some views I'd like to see at the same time, such as Rome IR and Prettier IR. Currently we're using tabs as our abstraction for navigating views, but it might be better to use tiles. Tiles allow multiple views to be available at once, and allows us to resize views that may not need to take up a lot of space.

@NicholasLYang NicholasLYang added task A task, an action that needs to be performed A-Tooling Area: our own build, development, and release tooling labels May 26, 2022
@ematipico ematipico added the good first issue Good for newcomers label May 27, 2022
@andreyvolfman
Copy link

andreyvolfman commented Jun 3, 2022

Hello! I have a proposal how to implement this feature. I created several drafts.
If you have any suggestions how to improve this mockups please let me know.
If everything is okay I will take this issue and send PR.

I suppose for mobile devices this solution is not suitable. We can create and
components. Does it sound good?

Thanks!

Screenshot 2022-06-03 at 10 44 12 AM

Screenshot 2022-06-03 at 10 48 08 AM

Screenshot 2022-06-03 at 10 41 42 AM

@ematipico
Copy link
Contributor

Hello! I have a proposal how to implement this feature. I created several drafts. If you have any suggestions how to improve this mockups please let me know. If everything is okay I will take this issue and send PR.

I suppose for mobile devices this solution is not suitable. We can create and components. Does it sound good?

Thanks!

Screenshot 2022-06-03 at 10 44 12 AM Screenshot 2022-06-03 at 10 48 08 AM Screenshot 2022-06-03 at 10 41 42 AM

Probably, we might want some view to be fixed, like Rome output for example (same as prettier's playground). How would that appear on mobile?

@andreyvolfman
Copy link

Updated drafts and mobile layout:

1. Desktop appearance
By default Input, Rome output and Prettier output tiles are enabled.

Desktop

2. Middle appearance (responsive layout from desktop to mobile resolution)
If element doesn't have enough space it will breaks to the next line.

Tablet

3. Mobile appearance
Settings panel extended with checkboxes.

Default state (Input tile is enabled):

Mobile_1

If press Settings button It will open settings panel.

Mobile_2

Select checkboxes with tiles and press Settings button again.

Mobile_3

Choosed tiles will be added to playground.

Mobile_4

@MichaReiser
Copy link
Contributor

@andreyvolfman that looks awesome!

@andreyvolfman
Copy link

andreyvolfman commented Jun 6, 2022

Great, thanks!
@MichaReiser can I solve this issue?:)

@MichaReiser
Copy link
Contributor

Great, thanks!

@MichaReiser can I solve this issue?:)

Sure! I'll assign the issue to you

@NicholasLYang
Copy link
Contributor Author

I like this idea! Some feedback:

  • I don't think we need a toggle for input.
  • To reduce visual clutter, we could group the Rome outputs and Prettier outputs
  • Instead of check boxes we could try using buttons that you can click and highlight

I did a quick mockup in Figma:
Screen Shot 2022-06-06 at 7 40 52 PM

@github-actions
Copy link

This issue is stale because it has been open 14 days with no activity.

@ematipico
Copy link
Contributor

@andreyvolfman this issue was assigned to you but it seems there haven't been progresses. Are you still interested?

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

This issue is stale because it has been open 14 days with no activity.

@github-actions
Copy link

This issue is stale because it has been open 14 days with no activity.

@dhrjarun
Copy link
Contributor

dhrjarun commented Nov 2, 2022

Hi, @MichaReiser if nobody is working on this can I work on this? I've created some layouts on figma https://www.figma.com/file/ZMJ4mENMTr3ISy6Y9F9GgP/Rome?node-id=0%3A1

Rome IR and Prettier IR grouped

Image

Resizable Playground with Settings

Image

Resizable Playground (Settings hidden)

Image

Resizable Playground mob (Only Settting)

Image

Resizable Playground mob (Settings hidden)

Image

@MichaReiser
Copy link
Contributor

@dhrjarun sure. These look great!

@ematipico ematipico added S-Planned Status: planned by the team, but not in the short term and removed S-Stale labels Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Tooling Area: our own build, development, and release tooling good first issue Good for newcomers S-Planned Status: planned by the team, but not in the short term task A task, an action that needs to be performed
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants