Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 usekeywithclickevents: Should not trigger for button #3638

Closed
1 task done
MichaReiser opened this issue Nov 10, 2022 · 1 comment
Closed
1 task done

🐛 usekeywithclickevents: Should not trigger for button #3638

MichaReiser opened this issue Nov 10, 2022 · 1 comment
Assignees
@MichaReiser
Labels
A-Linter Area: linter L-JavaScript Langauge: JavaScript S-Bug: confirmed Status: report has been confirmed as a valid bug
Milestone
10.0.1

Comments

@MichaReiser
Copy link
Contributor

Environment information

Rome v10

What happened?

Rome emits a diagnostic for

<button onClick={() => console.log("Test")} />

Expected result

Buttons don't need a onKeyEvent handler as buttons have this behavior built int

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@MichaReiser MichaReiser added S-Bug: confirmed Status: report has been confirmed as a valid bug A-Linter Area: linter L-JavaScript Langauge: JavaScript labels Nov 10, 2022
@MichaReiser MichaReiser added this to the 10.0.1 milestone Nov 10, 2022
@MichaReiser MichaReiser self-assigned this Nov 10, 2022
@leops
Copy link
Contributor

leops commented Nov 10, 2022

Fixed in #3644

@leops leops closed this as completed Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MichaReiser MichaReiser

Labels
A-Linter Area: linter L-JavaScript Langauge: JavaScript S-Bug: confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Milestone
10.0.1
Development

No branches or pull requests
2 participants
@MichaReiser @leops