No cond assign eslint implementation

[macovedj]

Going through #94. eslint has two options for this rule, one that allows exception via parens, and the other which would need ignoring to escape. I implemented the latter, because I don't think people should be encouraged to use paren, but I could implement it with parens if solid reasoning were provided.

[macovedj]

eslint has two options for this rule, one that allows exception via parens, and the other which would need ignoring to escape. I implemented the latter, because I don't think people should be encouraged to use paren, but I could implement it with parens if solid reasoning were provided.

Lol. The project currently violates this lint rule if we don't allow parens right here. It feels to me like there's a better way to do this, which I hope to have time to figure out tomorrow, but also I now see why parens would be desired. What do you think @sebmck?

[sebmck]

Heh, I believe that's code left over from babel-generator. You should be able to replace that with:

while (true) {
  const item = this._queue.pop();
  if (item === undefined) {
    break;
  } else {
    this._append(...item);
  }
}

Makes it a lot clearer what the code is doing.

Feel free to do that in this PR!

[sebmck]

The rest of the PR looks good to me!

[macovedj]

Heh, I believe that's code left over from babel-generator. You should be able to replace that with:

while (true) {
  const item = this._queue.pop();
  if (item === undefined) {
    break;
  } else {
    this._append(...item);
  }
}

Makes it a lot clearer what the code is doing.

Feel free to do that in this PR!

Done!

[sebmck]

Looks good, thank you!