Add disallowMultipleSpacesInRegularExpressionLiterals lint rule

[ikeryo1182]

Add no-regex-spaces lint rule on #94

[sebmck]

Could you hoist this regex to the top level of the file?

[ikeryo1182]

That's good. I fixed.

[sebmck]

This is missing normal regex literals. Is there any reason you didn't add a handler for RegExpLiteral?

[ikeryo1182]

This is missing normal regex literals. Is there any reason you didn't add a handler for RegExpLiteral?

Sorry, it is the lack of consideration
I added.

[sebmck]

This should be:

Suggested change

	(node.type === 'ExpressionStatement' &&
	node.expression.type === 'RegExpLiteral' &&
	multipleSpacesPattern.test(node.expression.pattern))
	(node.type === 'RegExpLiteral' &&
	multipleSpacesPattern.test(node.pattern))

It's overly specific because ExpressionStatement is only used as the wrapper statement for an expression. A regexp should never appear on a line by itself.

[ikeryo1182]

I see and accept suggestion, also fix conflict as soon as possible.

[ikeryo1182]

@sebmck
Hi.
Do you know why this below error occured in CircleCI ?

  ✖ Timed out after waiting 3000ms for Bridge.handshake

  1. Timeout._onTimeout (C:\Users\RUNNER~1\AppData\Local\Temp\rome-dev\index.js:4987:12)
    4985 │             listener.unsubscribe();
    4986 │             reject(
  > 4987 │             new Error('Timed out after waiting ' + timeout + 'ms for ' + this.name));
         │             ^ 
    4988 │           }, timeout);
    4989 │         }

  2. listOnTimeout (internal/timers.js:549:16)
  3. process.processTimers (internal/timers.js:492:6)

This diagnostic was derived from an internal Rome error. The problem likely isn't with your code. Please report this if necessary

It seems that all tests passed in local.

[sebmck]

Might be a transient error, nothing here that should cause it. Let me rerun CI and I'll see if it passes.

[sebmck]

Looks to be passing now, thank you!