This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmck
suggested changes
Mar 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Left a bunch of notes. There's a lot of redundant checks, missing return types, and some suboptimal soundness. Let me know if any of my comments aren't clear.
packages/@romejs/js-compiler/transforms/lint/noExtraBooleanCast.ts
Outdated
Show resolved
Hide resolved
packages/@romejs/js-compiler/transforms/lint/noExtraBooleanCast.ts
Outdated
Show resolved
Hide resolved
packages/@romejs/js-compiler/transforms/lint/noExtraBooleanCast.ts
Outdated
Show resolved
Hide resolved
packages/@romejs/js-compiler/transforms/lint/noExtraBooleanCast.ts
Outdated
Show resolved
Hide resolved
packages/@romejs/js-compiler/transforms/lint/noExtraBooleanCast.ts
Outdated
Show resolved
Hide resolved
packages/@romejs/js-compiler/transforms/lint/noExtraBooleanCast.ts
Outdated
Show resolved
Hide resolved
packages/@romejs/js-compiler/transforms/lint/noExtraBooleanCast.ts
Outdated
Show resolved
Hide resolved
packages/@romejs/js-compiler/transforms/lint/noExtraBooleanCast.ts
Outdated
Show resolved
Hide resolved
packages/@romejs/js-compiler/transforms/lint/noExtraBooleanCast.ts
Outdated
Show resolved
Hide resolved
zinyando
force-pushed
the
zinyando/no-extra-boolean-cast
branch
from
March 6, 2020 07:15
bd520be
to
63b2caa
Compare
yangshun
reviewed
Mar 8, 2020
zinyando
force-pushed
the
zinyando/no-extra-boolean-cast
branch
from
March 8, 2020 05:10
63b2caa
to
a94a1eb
Compare
Looks good, thank you @zinyando! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
no-extra-boolean-cast
lint check as part os issue #94.