Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

No extra boolean cast lint #141

Merged
merged 5 commits into from
Mar 8, 2020

Conversation

zinyando
Copy link
Contributor

@zinyando zinyando commented Mar 5, 2020

Adds a no-extra-boolean-cast lint check as part os issue #94.

Copy link
Contributor

@sebmck sebmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Left a bunch of notes. There's a lot of redundant checks, missing return types, and some suboptimal soundness. Let me know if any of my comments aren't clear.

@zinyando zinyando force-pushed the zinyando/no-extra-boolean-cast branch from bd520be to 63b2caa Compare March 6, 2020 07:15
@zinyando zinyando force-pushed the zinyando/no-extra-boolean-cast branch from 63b2caa to a94a1eb Compare March 8, 2020 05:10
@sebmck
Copy link
Contributor

sebmck commented Mar 8, 2020

Looks good, thank you @zinyando!

@sebmck sebmck merged commit 9863276 into rome:master Mar 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants